Skip to content

Commit b48c76b

Browse files
authored
prefer for-of (#106)
1 parent 0334ec8 commit b48c76b

File tree

1 file changed

+18
-18
lines changed

1 file changed

+18
-18
lines changed

esquery.js

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,9 @@ const RIGHT_SIDE = 'RIGHT_SIDE';
3434
*/
3535
function getPath(obj, key) {
3636
const keys = key.split('.');
37-
for (let i = 0; i < keys.length; i++) {
37+
for (const key of keys) {
3838
if (obj == null) { return obj; }
39-
obj = obj[keys[i]];
39+
obj = obj[key];
4040
}
4141
return obj;
4242
}
@@ -55,8 +55,8 @@ function inPath(node, ancestor, path) {
5555
const field = ancestor[path[0]];
5656
const remainingPath = path.slice(1);
5757
if (Array.isArray(field)) {
58-
for (let i = 0, l = field.length; i < l; ++i) {
59-
if (inPath(node, field[i], remainingPath)) { return true; }
58+
for (const component of field) {
59+
if (inPath(node, component, remainingPath)) { return true; }
6060
}
6161
return false;
6262
} else {
@@ -93,31 +93,31 @@ function matches(node, selector, ancestry) {
9393

9494
}
9595
case 'matches':
96-
for (let i = 0, l = selector.selectors.length; i < l; ++i) {
97-
if (matches(node, selector.selectors[i], ancestry)) { return true; }
96+
for (const sel of selector.selectors) {
97+
if (matches(node, sel, ancestry)) { return true; }
9898
}
9999
return false;
100100

101101
case 'compound':
102-
for (let i = 0, l = selector.selectors.length; i < l; ++i) {
103-
if (!matches(node, selector.selectors[i], ancestry)) { return false; }
102+
for (const sel of selector.selectors) {
103+
if (!matches(node, sel, ancestry)) { return false; }
104104
}
105105
return true;
106106

107107
case 'not':
108-
for (let i = 0, l = selector.selectors.length; i < l; ++i) {
109-
if (matches(node, selector.selectors[i], ancestry)) { return false; }
108+
for (const sel of selector.selectors) {
109+
if (matches(node, sel, ancestry)) { return false; }
110110
}
111111
return true;
112112

113113
case 'has': {
114114
const collector = [];
115-
for (let i = 0, l = selector.selectors.length; i < l; ++i) {
115+
for (const sel of selector.selectors) {
116116
const a = [];
117117
estraverse.traverse(node, {
118118
enter (node, parent) {
119119
if (parent != null) { a.unshift(parent); }
120-
if (matches(node, selector.selectors[i], a)) {
120+
if (matches(node, sel, a)) {
121121
collector.push(node);
122122
}
123123
},
@@ -237,8 +237,8 @@ function sibling(node, selector, ancestry, side) {
237237
const [parent] = ancestry;
238238
if (!parent) { return false; }
239239
const keys = estraverse.VisitorKeys[parent.type];
240-
for (let i = 0, l = keys.length; i < l; ++i) {
241-
const listProp = parent[keys[i]];
240+
for (const key of keys) {
241+
const listProp = parent[key];
242242
if (Array.isArray(listProp)) {
243243
const startIndex = listProp.indexOf(node);
244244
if (startIndex < 0) { continue; }
@@ -273,8 +273,8 @@ function adjacent(node, selector, ancestry, side) {
273273
const [parent] = ancestry;
274274
if (!parent) { return false; }
275275
const keys = estraverse.VisitorKeys[parent.type];
276-
for (let i = 0, l = keys.length; i < l; ++i) {
277-
const listProp = parent[keys[i]];
276+
for (const key of keys) {
277+
const listProp = parent[key];
278278
if (Array.isArray(listProp)) {
279279
const idx = listProp.indexOf(node);
280280
if (idx < 0) { continue; }
@@ -307,8 +307,8 @@ function nthChild(node, ancestry, idxFn) {
307307
const [parent] = ancestry;
308308
if (!parent) { return false; }
309309
const keys = estraverse.VisitorKeys[parent.type];
310-
for (let i = 0, l = keys.length; i < l; ++i) {
311-
const listProp = parent[keys[i]];
310+
for (const key of keys) {
311+
const listProp = parent[key];
312312
if (Array.isArray(listProp)) {
313313
const idx = listProp.indexOf(node);
314314
if (idx >= 0 && idx === idxFn(listProp.length)) { return true; }

0 commit comments

Comments
 (0)