feed_info.feed_lang is required (#229)

Author: AntoineAugusti

readme.md

@@ -163,7 +163,7 @@ Here is a human friendly list of them :
 | MissingName                      | Error       | An agency, a route or a stop has its name missing.                                                                                                                                       |
 | MissingCoordinates               | Warning     | A shape point or a stop is missing its coordinate(s).                                                                                                                                    |
 | NullDuration                     | Warning     | The travel duration between two stops is null.                                                                                                                                           |
-| MissingLanguage                  | Warning     | The publisher language code is missing.                                                                                                                                                  |
+| MissingLanguage                  | Warning|Error | The publisher language code is missing.                                                                                                                                                  |
 | InvalidLanguage                  | Warning     | The publisher language code is not valid.                                                                                                                                                |
 | DuplicateObjectId                | Error       | The object has at least one object with the same ID.                                                                                                                                     |
 | InvalidStopLocationTypeInTrip    | Warning     | Only Stop Points are allowed to be used in a Trip                                                                                                                                        |

src/validators/feed_info.rs

@@ -20,7 +20,7 @@ pub fn validate(gtfs: &gtfs_structures::Gtfs) -> Vec<Issue> {
         .feed_info
         .iter()
         .filter(missing_lang)
-        .map(|feed_info| make_issue(feed_info, Severity::Warning, IssueType::MissingLanguage));
+        .map(|feed_info| make_issue(feed_info, Severity::Error, IssueType::MissingLanguage));
     let invalid_lang = gtfs.feed_info.iter().filter(invalid_lang).map(|feed_info| {
         make_issue(feed_info, Severity::Warning, IssueType::InvalidLanguage)
             .details(&format!("Language code {} does not exist", feed_info.lang))
@@ -105,6 +105,7 @@ fn test_missing_lang() {
 
     assert_eq!(1, missing_lang_issue.len());
     assert_eq!(IssueType::MissingLanguage, missing_lang_issue[0].issue_type);
+    assert_eq!(Severity::Error, missing_lang_issue[0].severity);
 }
 
 #[test]
@@ -118,6 +119,7 @@ fn test_valid_lang() {
         .collect();
     assert_eq!(1, invalid_lang_issue.len());
     assert_eq!(IssueType::InvalidLanguage, invalid_lang_issue[0].issue_type);
+    assert_eq!(Severity::Warning, invalid_lang_issue[0].severity);
 }
 
 #[test]