Skip to content

Commit 18220df

Browse files
authored
Merge pull request #21503 from fuweid/fix-flaky-test
tests/integration: fix flaky testcase
2 parents 5791f2b + fe4b891 commit 18220df

File tree

1 file changed

+15
-20
lines changed

1 file changed

+15
-20
lines changed

tests/integration/v3_auth_test.go

Lines changed: 15 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -429,8 +429,9 @@ func TestV3AuthNestedTxnPermissionDenied(t *testing.T) {
429429
end: "zoo",
430430
},
431431
}
432-
authSetupUsers(t, integration.ToGRPC(clus.Client(0)).Auth, users)
433-
authSetupRoot(t, integration.ToGRPC(clus.Client(0)).Auth)
432+
anonCli := integration.ToGRPC(clus.Client(0))
433+
authSetupUsers(t, anonCli.Auth, users)
434+
authSetupRoot(t, anonCli.Auth)
434435

435436
rootc, err := integration.NewClient(t, clientv3.Config{
436437
Endpoints: clus.Client(0).Endpoints(),
@@ -451,27 +452,21 @@ func TestV3AuthNestedTxnPermissionDenied(t *testing.T) {
451452
_, err = rootc.Put(t.Context(), "boo", "bar")
452453
require.NoError(t, err)
453454

454-
txn := &pb.TxnRequest{
455-
Success: []*pb.RequestOp{
456-
{
457-
Request: &pb.RequestOp_RequestTxn{
458-
RequestTxn: &pb.TxnRequest{
459-
Success: []*pb.RequestOp{
460-
{
461-
Request: &pb.RequestOp_RequestDeleteRange{
462-
RequestDeleteRange: &pb.DeleteRangeRequest{
463-
Key: []byte("boo"),
464-
},
465-
},
466-
},
467-
},
455+
_, err = userc.Txn(t.Context()).
456+
Then(clientv3.OpTxn(
457+
nil,
458+
[]clientv3.Op{
459+
clientv3.OpTxn(
460+
nil,
461+
[]clientv3.Op{
462+
clientv3.OpDelete("boo"),
468463
},
469-
},
464+
nil,
465+
),
470466
},
471-
},
472-
}
467+
nil,
468+
)).Commit()
473469

474-
_, err = integration.ToGRPC(userc).KV.Txn(t.Context(), txn)
475470
require.Error(t, err)
476471
require.Truef(t, eqErrGRPC(err, rpctypes.ErrGRPCPermissionDenied), "got %v, expected %v", err, rpctypes.ErrGRPCPermissionDenied)
477472

0 commit comments

Comments
 (0)