Skip to content

Commit a8fee10

Browse files
committed
server/embed: Log EOF on DEBUG in TLS handshake
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
1 parent 4174d1d commit a8fee10

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

server/embed/config_logging.go

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ import (
1919
"encoding/json"
2020
"errors"
2121
"fmt"
22+
"io"
2223
"io/ioutil"
2324
"net/url"
2425
"os"
@@ -149,6 +150,12 @@ func (cfg *Config) setupLogging() error {
149150

150151
logTLSHandshakeFailureFunc := func(msg string) func(conn *tls.Conn, err error) {
151152
return func(conn *tls.Conn, err error) {
153+
// Log EOF errors on DEBUG not to spam logs too much.
154+
logFunc := cfg.logger.Warn
155+
if errors.Is(err, io.EOF) {
156+
logFunc = cfg.logger.Debug
157+
}
158+
152159
state := conn.ConnectionState()
153160
remoteAddr := conn.RemoteAddr().String()
154161
serverName := state.ServerName
@@ -158,7 +165,7 @@ func (cfg *Config) setupLogging() error {
158165
for i := range cert.IPAddresses {
159166
ips[i] = cert.IPAddresses[i].String()
160167
}
161-
cfg.logger.Warn(
168+
logFunc(
162169
msg,
163170
zap.String("remote-addr", remoteAddr),
164171
zap.String("server-name", serverName),
@@ -167,7 +174,7 @@ func (cfg *Config) setupLogging() error {
167174
zap.Error(err),
168175
)
169176
} else {
170-
cfg.logger.Warn(
177+
logFunc(
171178
msg,
172179
zap.String("remote-addr", remoteAddr),
173180
zap.String("server-name", serverName),

0 commit comments

Comments
 (0)