[#510]: Invoke Maestro CI via single-line bash script file

android-emulator-runner runs each script line as sh -c; multiline
heredocs still break. Move Gradle/Maestro into scripts/maestro-ci-emulator.sh.

Author: mattrace-gloo

.github/workflows/maestro-android.yml

@@ -97,12 +97,12 @@ jobs:
         env:
           CI: 'true'
 
-      # Assemble inside emulator-runner so ANDROID_HOME / SDK from the action are available.
-      # android-emulator-runner invokes script with /usr/bin/sh (dash on ubuntu) — run the
-      # body via a bash heredoc so `pipefail` and ${HOME} expansion work (#510).
+      # android-emulator-runner runs *each line* of `script:` as a separate
+      # `/usr/bin/sh -c` (dash). Keep this a single line that execs a bash file (#510).
       - name: Build APK + run Maestro on emulator
         uses: reactivecircus/android-emulator-runner@1dcd0090116d15e7c562f8db72807de5e036a4ed # v2.34.0
         env:
+          MAESTRO_SUITE: ${{ inputs.suite }}
           MAESTRO_EMAIL: ${{ secrets.MAESTRO_EMAIL }}
           MAESTRO_PASSWORD: ${{ secrets.MAESTRO_PASSWORD }}
           MAESTRO_EMAIL_2: ${{ secrets.MAESTRO_EMAIL_2 }}
@@ -115,36 +115,7 @@ jobs:
           disable-animations: true
           emulator-options: -no-window -gpu swiftshader_indirect -noaudio -no-boot-anim -no-metrics
           emulator-boot-timeout: 900
-          script: |
-            bash -euo pipefail <<'SCRIPT'
-            export PATH="${HOME}/.maestro/bin:${PATH}"
-            chmod +x android/gradlew
-            (
-              cd android
-              ./gradlew :app:assembleRelease --no-daemon -PreactNativeArchitectures=x86_64
-            )
-            APK="android/app/build/outputs/apk/release/app-release.apk"
-            test -f "${APK}"
-            adb install -r "${APK}"
-            mkdir -p .maestro/test_output
-            suite="${{ inputs.suite }}"
-            case "${suite}" in
-              harness)
-                npm run maestro:test:harness -- --format junit --output .maestro/test_output/report.xml
-                ;;
-              smokes)
-                npm run maestro:test:smokes -- --format junit --output .maestro/test_output/report.xml
-                ;;
-              multi-account)
-                npm run maestro:test:multi-account -- --format junit --output .maestro/test_output/report.xml
-                ;;
-              *)
-                echo "Unknown suite: ${suite}" >&2
-                exit 1
-                ;;
-            esac
-            adb logcat -d > .maestro/test_output/logcat.txt || true
-            SCRIPT
+          script: bash ./scripts/maestro-ci-emulator.sh
 
       - name: Upload Maestro artifacts
         if: always()

docs/guides/maestro.md

@@ -45,7 +45,7 @@ Opt-in **Android-only** Maestro suite for Fluent Mobile ([#488](https://github.c
 
 Dispatch: **Actions → Maestro Android (informational) → Run workflow** (after the workflow exists on the target branch / `main`). Artifacts: JUnit + Maestro output + APK (14-day retention).
 
-Note: `android-emulator-runner` runs its `script` under `/usr/bin/sh` (dash on Ubuntu). The workflow runs the body through a `bash -euo pipefail` heredoc so bashisms like `pipefail` work (#510).
+Note: `android-emulator-runner` runs **each line** of `script:` as a separate `/usr/bin/sh -c` (dash on Ubuntu). The workflow keeps `script:` to one line — `bash ./scripts/maestro-ci-emulator.sh` — so bashisms and multiline Gradle/Maestro logic live in that script file (#510).
 
 See also [docs/ci.md](../ci.md) and [`.github/README.md`](../../.github/README.md).
 

scripts/maestro-ci-emulator.sh

@@ -0,0 +1,41 @@
+#!/usr/bin/env bash
+# Invoked as a *single line* by android-emulator-runner (that action runs each
+# `script:` line via `/usr/bin/sh -c`, so multiline YAML scripts break).
+# Expects: repo root CWD, ANDROID_HOME from emulator-runner, MAESTRO_SUITE set.
+set -euo pipefail
+
+ROOT="$(cd "$(dirname "$0")/.." && pwd)"
+cd "$ROOT"
+
+export PATH="${HOME}/.maestro/bin:${PATH}"
+
+chmod +x android/gradlew
+(
+  cd android
+  ./gradlew :app:assembleRelease --no-daemon -PreactNativeArchitectures=x86_64
+)
+
+APK="android/app/build/outputs/apk/release/app-release.apk"
+test -f "${APK}"
+adb install -r "${APK}"
+
+mkdir -p .maestro/test_output
+suite="${MAESTRO_SUITE:?MAESTRO_SUITE is required (harness|smokes|multi-account)}"
+
+case "${suite}" in
+  harness)
+    npm run maestro:test:harness -- --format junit --output .maestro/test_output/report.xml
+    ;;
+  smokes)
+    npm run maestro:test:smokes -- --format junit --output .maestro/test_output/report.xml
+    ;;
+  multi-account)
+    npm run maestro:test:multi-account -- --format junit --output .maestro/test_output/report.xml
+    ;;
+  *)
+    echo "Unknown MAESTRO_SUITE: ${suite}" >&2
+    exit 1
+    ;;
+esac
+
+adb logcat -d > .maestro/test_output/logcat.txt || true