Skip to content

Commit 8728abb

Browse files
[#411]: Align hasTake with displayRows and clear stitch on selectTake
Gate review chrome on visible My Takes rows in pericope mode and drop stitched playback state when the user selects a real take row.
1 parent 540bea4 commit 8728abb

2 files changed

Lines changed: 7 additions & 4 deletions

File tree

src/app/tabs/RecordTab.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -212,9 +212,6 @@ export function RecordTab({
212212
const prevDisabled = verseIndex <= 0;
213213
const nextDisabled = verseIndex < 0 || verseIndex >= verses.length - 1;
214214
const selected = verses.find(v => v.verseNumber === selectedVerse);
215-
const hasTake = verseAudio.takes.length > 0;
216-
const hasAnyTake = hasTake || verseAudio.allTakes.length > 0;
217-
const activeViewHasTakes = takeView === 'mine' ? hasTake : hasAnyTake;
218215

219216
const resolveBibleTextId = useCallback(async () => {
220217
return getBibleTextId(
@@ -296,6 +293,10 @@ export function RecordTab({
296293
],
297294
);
298295

296+
const hasTake = displayRows.length > 0;
297+
const hasAnyTake = hasTake || verseAudio.allTakes.length > 0;
298+
const activeViewHasTakes = takeView === 'mine' ? hasTake : hasAnyTake;
299+
299300
/** Shared generation so sync-triggered and verse-change lookups ignore stale IDs. */
300301
const bibleTextRequestIdRef = useRef(0);
301302

src/hooks/useVerseAudio.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -799,6 +799,8 @@ export function useVerseAudio({
799799
const selectTake = useCallback(
800800
async (id: string) => {
801801
try {
802+
clearStitchQueue();
803+
setPlayingTakeId(null);
802804
await selectTakeFn(id);
803805
if (bibleTextId !== null) {
804806
setTakes(await loadTakesFn(bibleTextId));
@@ -810,7 +812,7 @@ export function useVerseAudio({
810812
dispatch({ type: 'ERROR', message });
811813
}
812814
},
813-
[bibleTextId, loadTakesFn, selectTakeFn],
815+
[bibleTextId, clearStitchQueue, loadTakesFn, selectTakeFn],
814816
);
815817

816818
/** Designate canonical from All Takes (#279) — any account may call this. */

0 commit comments

Comments
 (0)