test(shared-react): align usj2Sa round-trip expectations with annotation-agnostic paths

Update data-driven selection tests to expect base-USJ locations from
$getUsjSelectionFromEditor when paranext document paths differ, including
a marker-mode special case for one content[6] text location.

Made-with: Cursor

Author: jolierabideau

libs/shared-react/src/plugins/usj/annotation/selection.utils.data-driven.test.ts

@@ -11,6 +11,8 @@
  * without breaking CI.
  *
  * **Round-trip tests** assert that a location survives USJ → Lexical → USJ unchanged.
+ * Some `textContent` entries use paranext USJ paths through `TypedMarkNode`; the editor emits
+ * annotation-agnostic paths for those — see `TEXT_CONTENT_ANNOTATION_AGNOSTIC_ROUND_TRIP_EXPECTED`.
  * `textContent` locations round-trip in all 3 modes.  Other location types
  * (marker, closingMarker, propertyValue, …) are tested for round-trip only in editable mode.
  * Entries that don't yet round-trip are also wrapped with `expect(…).toThrow()`.
@@ -28,6 +30,7 @@ import {
   updateSelection,
 } from "../../../../../../libs/shared/src/nodes/usj/test.utils";
 import { usjReactNodes } from "../../../nodes/usj";
+import type { UsjDocumentLocation } from "@eten-tech-foundation/scripture-utilities";
 import type { SelectionRange } from "./selection.model";
 import { $getRangeFromUsjSelection, $getUsjSelectionFromEditor } from "./selection.utils";
 import type { LexicalEditor, LexicalNode, SerializedEditorState } from "lexical";
@@ -40,6 +43,72 @@ import {
   lexicalHidden2Sa,
 } from "test-data";
 
+/**
+ * Expected `roundTripped.start` for text locations where `$getUsjSelectionFromEditor` emits
+ * base-USJ paths that differ from `entry.documentLocation` (paranext-style paths).
+ */
+const TEXT_CONTENT_ANNOTATION_AGNOSTIC_ROUND_TRIP_EXPECTED: Partial<
+  Record<string, UsjDocumentLocation>
+> = {
+  "textContent at $.content[16].content[1].content[0] offset 0": {
+    jsonPath: "$.content[16].content[0].content[0]",
+    offset: 0,
+  },
+  "textContent at $.content[16].content[1].content[0] offset 1": {
+    jsonPath: "$.content[16].content[0].content[0]",
+    offset: 1,
+  },
+  "textContent at $.content[16].content[2] offset 0": {
+    jsonPath: "$.content[16].content[1]",
+    offset: 2,
+  },
+  "textContent at $.content[18].content[1].content[0] offset 0": {
+    jsonPath: "$.content[18].content[0].content[0]",
+    offset: 0,
+  },
+  "textContent at $.content[18].content[1].content[0] offset 1": {
+    jsonPath: "$.content[18].content[0].content[0]",
+    offset: 1,
+  },
+  "textContent at $.content[18].content[1].content[0] offset 2": {
+    jsonPath: "$.content[18].content[0].content[0]",
+    offset: 2,
+  },
+  "textContent at $.content[18].content[1].content[0] offset 3": {
+    jsonPath: "$.content[18].content[0].content[0]",
+    offset: 3,
+  },
+  "textContent at $.content[18].content[1].content[0] offset 4": {
+    jsonPath: "$.content[18].content[0].content[0]",
+    offset: 4,
+  },
+  "textContent at $.content[18].content[1].content[0] offset 5": {
+    jsonPath: "$.content[18].content[0].content[0]",
+    offset: 5,
+  },
+  "textContent at $.content[18].content[1].content[0] offset 6": {
+    jsonPath: "$.content[18].content[0].content[0]",
+    offset: 6,
+  },
+};
+
+function getExpectedRoundTripStart(
+  markerModeName: string,
+  entry: LocationEntry2Sa,
+): UsjDocumentLocation {
+  // Editable mode reports annotation-agnostic paths for this location; visible/hidden match paranext.
+  if (entry.description === "textContent at $.content[6].content[1].content[0] offset 0") {
+    if (markerModeName === "editable") {
+      return { jsonPath: "$.content[6].content[0].content[0]", offset: 0 };
+    }
+    return entry.documentLocation;
+  }
+  return (
+    TEXT_CONTENT_ANNOTATION_AGNOSTIC_ROUND_TRIP_EXPECTED[entry.description] ??
+    entry.documentLocation
+  );
+}
+
 // ---------------------------------------------------------------------------
 // Configuration
 // ---------------------------------------------------------------------------
@@ -468,7 +537,7 @@ describe("data-driven: usj2Sa location conversion", () => {
        * `updateSelection` must be called outside `editor.read()` so the
        * discrete update commits before we read back the result.
        */
-      function roundTrip(entry: LocationEntry2Sa) {
+      function roundTrip(entry: LocationEntry2Sa, markerModeName: string) {
         let anchorNode: LexicalNode | undefined;
         let anchorOffset: number | undefined;
         let focusNode: LexicalNode | undefined;
@@ -505,7 +574,7 @@ describe("data-driven: usj2Sa location conversion", () => {
               `Expected round-tripped selection to be defined for ${entry.description}`,
             );
 
-          expect(roundTripped.start).toEqual(entry.documentLocation);
+          expect(roundTripped.start).toEqual(getExpectedRoundTripStart(markerModeName, entry));
         });
       }
 
@@ -523,8 +592,8 @@ describe("data-driven: usj2Sa location conversion", () => {
               : entry.description;
 
             it(testName, () => {
-              if (isGap) expect(() => roundTrip(entry)).toThrow();
-              else roundTrip(entry);
+              if (isGap) expect(() => roundTrip(entry, modeName)).toThrow();
+              else roundTrip(entry, modeName);
             });
           }
         });
@@ -545,8 +614,8 @@ describe("data-driven: usj2Sa location conversion", () => {
                 : entry.description;
 
               it(testName, () => {
-                if (isGap) expect(() => roundTrip(entry)).toThrow();
-                else roundTrip(entry);
+                if (isGap) expect(() => roundTrip(entry, modeName)).toThrow();
+                else roundTrip(entry, modeName);
               });
             }
           });