Add tests for currency conversion feature

- Add CurrencyHelper spec (18 examples)
- Add ExchangeRateService spec (16 examples)
- Add CurrenciesController request spec (8 examples)

Also fix ExchangeRateService to store timestamp in exchange_rates JSON
instead of requiring a separate column.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: etewiah

app/services/pwb/exchange_rate_service.rb

@@ -49,9 +49,9 @@ def update_rates(website)
 
         rates = build_rates_hash(bank, base_currency, target_currencies)
 
+        # Store rates with timestamp in the JSON column
         website.update!(
-          exchange_rates: rates,
-          exchange_rates_updated_at: Time.current
+          exchange_rates: rates.merge('_updated_at' => Time.current.iso8601)
         )
 
         Rails.logger.info "[ExchangeRates] Updated #{rates.size} rates for website #{website.id}"
@@ -132,9 +132,15 @@ def convert(money, to_currency, website)
       # @param website [Pwb::Website] the website to check
       # @return [Boolean] true if rates need updating
       def rates_stale?(website)
-        return true if website.exchange_rates_updated_at.nil?
+        rates = website.exchange_rates
+        return true if rates.blank?
+
+        updated_at = rates['_updated_at']
+        return true if updated_at.nil?
 
-        website.exchange_rates_updated_at < 24.hours.ago
+        Time.parse(updated_at) < 24.hours.ago
+      rescue ArgumentError
+        true
       end
 
       # Get list of available currencies from ECB

spec/helpers/currency_helper_spec.rb

@@ -0,0 +1,138 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+RSpec.describe CurrencyHelper, type: :helper do
+  let(:website) { create(:pwb_website, default_currency: 'EUR', available_currencies: ['USD', 'GBP']) }
+
+  before do
+    # Set up current website context
+    allow(helper).to receive(:current_website).and_return(website)
+    allow(helper).to receive(:session).and_return({})
+    allow(helper).to receive(:cookies).and_return({})
+  end
+
+  describe '#display_price' do
+    let(:price) { Money.new(25000000, 'EUR') } # €250,000
+
+    context 'with nil price' do
+      it 'returns nil' do
+        expect(helper.display_price(nil)).to be_nil
+      end
+    end
+
+    context 'with zero price' do
+      it 'returns nil' do
+        expect(helper.display_price(Money.new(0, 'EUR'))).to be_nil
+      end
+    end
+
+    context 'when user has not selected a different currency' do
+      it 'returns formatted price without conversion' do
+        result = helper.display_price(price)
+        expect(result).to include('€')
+        expect(result).to include('250,000')
+        expect(result).not_to include('(~')
+      end
+    end
+
+    context 'when show_conversion is false' do
+      it 'returns only the original price' do
+        allow(helper).to receive(:session).and_return({ preferred_currency: 'USD' })
+        result = helper.display_price(price, show_conversion: false)
+        expect(result).to include('€')
+        expect(result).not_to include('(~')
+      end
+    end
+  end
+
+  describe '#user_preferred_currency' do
+    context 'with session preference' do
+      it 'returns session currency' do
+        allow(helper).to receive(:session).and_return({ preferred_currency: 'USD' })
+        expect(helper.user_preferred_currency).to eq('USD')
+      end
+    end
+
+    context 'with cookie preference' do
+      it 'returns cookie currency' do
+        allow(helper).to receive(:session).and_return({})
+        allow(helper).to receive(:cookies).and_return({ preferred_currency: 'GBP' })
+        expect(helper.user_preferred_currency).to eq('GBP')
+      end
+    end
+
+    context 'with no preference' do
+      it 'returns website default currency' do
+        expect(helper.user_preferred_currency).to eq('EUR')
+      end
+    end
+  end
+
+  describe '#available_display_currencies' do
+    it 'includes the default currency' do
+      expect(helper.available_display_currencies).to include('EUR')
+    end
+
+    it 'includes additional currencies' do
+      expect(helper.available_display_currencies).to include('USD', 'GBP')
+    end
+
+    it 'returns unique values' do
+      website.update(available_currencies: ['EUR', 'USD', 'EUR'])
+      result = helper.available_display_currencies
+      expect(result.count('EUR')).to eq(1)
+    end
+  end
+
+  describe '#multiple_currencies_available?' do
+    context 'with multiple currencies' do
+      it 'returns true' do
+        expect(helper.multiple_currencies_available?).to be true
+      end
+    end
+
+    context 'with only default currency' do
+      before do
+        website.update(available_currencies: [])
+      end
+
+      it 'returns false' do
+        expect(helper.multiple_currencies_available?).to be false
+      end
+    end
+  end
+
+  describe '#currency_symbol' do
+    it 'returns € for EUR' do
+      expect(helper.currency_symbol('EUR')).to eq('€')
+    end
+
+    it 'returns $ for USD' do
+      expect(helper.currency_symbol('USD')).to eq('$')
+    end
+
+    it 'returns £ for GBP' do
+      expect(helper.currency_symbol('GBP')).to eq('£')
+    end
+
+    it 'returns code for unknown currency' do
+      expect(helper.currency_symbol('XXX')).to eq('XXX')
+    end
+  end
+
+  describe '#currency_select_options' do
+    it 'returns array of label/value pairs' do
+      options = helper.currency_select_options
+      expect(options).to be_an(Array)
+      expect(options.first).to be_an(Array)
+      expect(options.first.size).to eq(2)
+    end
+
+    it 'includes symbols in labels' do
+      options = helper.currency_select_options
+      labels = options.map(&:first)
+      expect(labels.join).to include('€')
+    end
+  end
+end

spec/requests/pwb/currencies_spec.rb

@@ -0,0 +1,92 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+RSpec.describe 'Currency Selection', type: :request do
+  let(:website) do
+    create(:pwb_website,
+           subdomain: 'currency-test',
+           default_currency: 'EUR',
+           available_currencies: ['USD', 'GBP'])
+  end
+  let!(:agency) { create(:pwb_agency, website: website) }
+
+  before do
+    # Set up tenant context
+    host! "#{website.subdomain}.test.host"
+    Pwb::Current.website = website
+    ActsAsTenant.current_tenant = website
+  end
+
+  describe 'POST /set_currency' do
+    context 'with valid currency' do
+      it 'sets the currency preference and redirects' do
+        post '/set_currency', params: { currency: 'USD' }
+
+        expect(response).to have_http_status(:redirect)
+        expect(session[:preferred_currency]).to eq('USD')
+      end
+
+      it 'stores currency in cookie' do
+        post '/set_currency', params: { currency: 'GBP' }
+
+        expect(cookies[:preferred_currency]).to eq('GBP')
+      end
+
+      context 'with JSON format' do
+        it 'returns success JSON' do
+          post '/set_currency', params: { currency: 'USD' }, as: :json
+
+          expect(response).to have_http_status(:success)
+          json = JSON.parse(response.body)
+          expect(json['success']).to be true
+          expect(json['currency']).to eq('USD')
+        end
+      end
+    end
+
+    context 'with invalid currency' do
+      it 'redirects with error' do
+        post '/set_currency', params: { currency: 'XXX' }
+
+        expect(response).to have_http_status(:redirect)
+      end
+
+      context 'with JSON format' do
+        it 'returns error JSON' do
+          post '/set_currency', params: { currency: 'XXX' }, as: :json
+
+          expect(response).to have_http_status(:unprocessable_entity)
+          json = JSON.parse(response.body)
+          expect(json['success']).to be false
+        end
+      end
+    end
+
+    context 'with currency not in available list' do
+      it 'rejects the currency' do
+        post '/set_currency', params: { currency: 'JPY' }, as: :json
+
+        expect(response).to have_http_status(:unprocessable_entity)
+      end
+    end
+
+    context 'with blank currency' do
+      it 'rejects the request' do
+        post '/set_currency', params: { currency: '' }, as: :json
+
+        expect(response).to have_http_status(:unprocessable_entity)
+      end
+    end
+
+    context 'with lowercase currency code' do
+      it 'accepts and normalizes to uppercase' do
+        post '/set_currency', params: { currency: 'usd' }, as: :json
+
+        expect(response).to have_http_status(:success)
+        json = JSON.parse(response.body)
+        expect(json['currency']).to eq('USD')
+      end
+    end
+  end
+end