Fix N+1 queries on home page property listings

Before: 83 queries, 579ms response time
After: 28 queries, 278ms response time

Changes:
- Convert sale_listing/rental_listing methods to belongs_to associations
  in Pwb::ListedProperty so they can be eager loaded
- Update with_eager_loading scope to include :sale_listing and
  :rental_listing associations

The N+1 was caused by sale_listing and rental_listing being methods
that called find_by individually for each property, instead of
associations that could be preloaded in a single query.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: etewiah

app/models/concerns/listed_property/searchable.rb

@@ -8,11 +8,16 @@ module Searchable
 
     included do
       # Eager load photos with their ActiveStorage attachments for efficient image access
-      # Also includes :website to prevent N+1 when accessing area_unit, currency, etc.
-      scope :with_eager_loading, -> { includes(:website, prop_photos: { image_attachment: :blob }) }
+      # Also includes :website, :sale_listing, :rental_listing to prevent N+1 queries
+      # when accessing area_unit, currency, title, description, prices, etc.
+      scope :with_eager_loading, -> {
+        includes(:website, :sale_listing, :rental_listing, prop_photos: { image_attachment: :blob })
+      }
 
       # Use this when you need both website and photos (e.g., cross-tenant operations)
-      scope :with_full_eager_loading, -> { includes(:website, prop_photos: { image_attachment: :blob }) }
+      scope :with_full_eager_loading, -> {
+        includes(:website, :sale_listing, :rental_listing, prop_photos: { image_attachment: :blob })
+      }
 
       # Lighter scope for widgets - only loads photos without attachment blob data
       # Use when you only need first photo or just need to check has_image?

app/models/pwb/listed_property.rb

@@ -108,6 +108,10 @@ class ListedProperty < ApplicationRecord
 
     belongs_to :website, class_name: 'Pwb::Website', optional: true
 
+    # Listing associations - these can be eager loaded to avoid N+1 queries
+    belongs_to :sale_listing, class_name: 'Pwb::SaleListing', optional: true
+    belongs_to :rental_listing, class_name: 'Pwb::RentalListing', optional: true
+
     has_many :prop_photos,
              -> { order(:sort_order) },
              class_name: 'Pwb::PropPhoto',
@@ -127,14 +131,6 @@ def realty_asset
       Pwb::RealtyAsset.find(id)
     end
 
-    def sale_listing
-      Pwb::SaleListing.find_by(id: sale_listing_id) if sale_listing_id.present?
-    end
-
-    def rental_listing
-      Pwb::RentalListing.find_by(id: rental_listing_id) if rental_listing_id.present?
-    end
-
     # ============================================
     # Read-Only Protection
     # ============================================