Fix memoization issues in styleable and setup specs

Use fresh database instances instead of reloaded objects in tests
where memoized @current_theme needs to be cleared. Calling reload
on a model doesn't clear memoized instance variables.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: etewiah

spec/models/concerns/pwb/website_styleable_spec.rb

@@ -139,8 +139,10 @@
 
     it "returns nil for invalid theme_name" do
       website.update_column(:theme_name, "nonexistent")
+      # Get a fresh instance since reload doesn't clear memoized @current_theme
+      fresh_website = Pwb::Website.find(website.id)
 
-      expect(website.current_theme).to be_nil
+      expect(fresh_website.current_theme).to be_nil
     end
 
     it "memoizes the result" do
@@ -190,12 +192,12 @@
     end
 
     context "with no current theme" do
-      before do
+      it "returns nil" do
         website.update_column(:theme_name, "nonexistent")
-      end
+        # Get a fresh instance since reload doesn't clear memoized @current_theme
+        fresh_website = Pwb::Website.find(website.id)
 
-      it "returns nil" do
-        expect(website.effective_palette_id).to be_nil
+        expect(fresh_website.effective_palette_id).to be_nil
       end
     end
   end
@@ -234,8 +236,10 @@
 
     it "returns false when no theme" do
       website.update_column(:theme_name, "nonexistent")
+      # Get a fresh instance since reload doesn't clear memoized @current_theme
+      fresh_website = Pwb::Website.find(website.id)
 
-      result = website.apply_palette!("ocean_blue")
+      result = fresh_website.apply_palette!("ocean_blue")
 
       expect(result).to be false
     end
@@ -254,8 +258,10 @@
 
     it "returns empty hash when no theme" do
       website.update_column(:theme_name, "nonexistent")
+      # Get a fresh instance since reload doesn't clear memoized @current_theme
+      fresh_website = Pwb::Website.find(website.id)
 
-      expect(website.available_palettes).to eq({})
+      expect(fresh_website.available_palettes).to eq({})
     end
 
     it "returns theme-specific palettes" do
@@ -289,8 +295,10 @@
 
     it "returns empty array when no theme" do
       website.update_column(:theme_name, "nonexistent")
+      # Get a fresh instance since reload doesn't clear memoized @current_theme
+      fresh_website = Pwb::Website.find(website.id)
 
-      expect(website.palette_options_for_select).to eq([])
+      expect(fresh_website.palette_options_for_select).to eq([])
     end
   end
 

spec/models/pwb/website_spec.rb

@@ -238,9 +238,11 @@ module Pwb
         expect(website.selected_palette).to eq('ocean_blue')
       end
 
-      it 'defaults to nil' do
+      it 'defaults to theme default palette when theme has palettes' do
+        # Website factory sets theme_name to 'default', which triggers ensure_palette_selected
+        # to auto-set the theme's default palette
         new_website = FactoryBot.create(:pwb_website)
-        expect(new_website.selected_palette).to be_nil
+        expect(new_website.selected_palette).to eq('classic_red')
       end
     end
 
@@ -255,8 +257,11 @@ module Pwb
 
       it 'returns nil for invalid theme' do
         website.update_column(:theme_name, 'nonexistent')
+        # Get a fresh instance since update_column bypasses callbacks and
+        # reload doesn't clear memoized @current_theme
+        fresh_website = Pwb::Website.find(website.id)
 
-        expect(website.current_theme).to be_nil
+        expect(fresh_website.current_theme).to be_nil
       end
     end
 
@@ -337,8 +342,11 @@ module Pwb
 
       it 'returns empty hash when no theme' do
         website.update_column(:theme_name, 'nonexistent')
+        # Get a fresh instance since update_column bypasses callbacks and
+        # reload doesn't clear memoized @current_theme
+        fresh_website = Pwb::Website.find(website.id)
 
-        expect(website.available_palettes).to eq({})
+        expect(fresh_website.available_palettes).to eq({})
       end
     end
 

spec/requests/pwb/setup_spec.rb

@@ -6,6 +6,19 @@
   # Setup controller handles initial website creation when no website exists
   # for the current subdomain. This is the onboarding flow for new tenants.
 
+  # Ensure TenantSettings allows all themes for tests
+  before(:all) do
+    Pwb::TenantSettings.delete_all
+    Pwb::TenantSettings.create!(
+      singleton_key: 'default',
+      default_available_themes: %w[default brisbane bologna barcelona biarritz]
+    )
+  end
+
+  after(:all) do
+    Pwb::TenantSettings.delete_all
+  end
+
   describe 'GET /setup (index)' do
     context 'when no website exists for subdomain' do
       it 'renders the setup page successfully' do
@@ -84,8 +97,8 @@
         website = Pwb::Website.find_by(subdomain: 'themedsite')
         # Website should be created with some theme (default or from pack)
         expect(website).to be_present
-        # Theme defaults to 'default' if not specified in pack
-        expect(website.theme_name).to eq('default').or eq('brisbane').or be_nil
+        # netherlands_urban pack uses 'bologna' theme
+        expect(website.theme_name).to eq('bologna')
       end
     end