Skip to content

Commit 4d051da

Browse files
committed
resolve the mentioned todos
1 parent b1ac1de commit 4d051da

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

docs/services/cicd.md

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,9 @@ build_job:
4747
DOCKERFILE: ci/docker/Dockerfile.build
4848
```
4949

50-
This adds a job named `build_job` to the stage `build`. This runner expects a Dockerfile as input, which is specified in the variable `DOCKERFILE`. The resulting container name is specified with the variable `PERSIST_IMAGE_NAME`, which has been defined already above, therefore it does not need to be explicitly mentioned in the `variables` block, again. There is further documentation of this runner at gitlab-runner-k8s-container-builder.
51-
!!! todo
52-
link to runner specs
50+
This adds a job named `build_job` to the stage `build`. This runner expects a Dockerfile as input, which is specified in the variable `DOCKERFILE`.
51+
The resulting container name is specified with the variable `PERSIST_IMAGE_NAME`, which has been defined already above, therefore it does not need to be explicitly mentioned in the `variables` block, again.
52+
Further refinements can be found at the [reference documentation](#container-builder)
5353

5454
```yaml
5555
test_job:
@@ -63,9 +63,7 @@ test_job:
6363
SLURM_NTASKS: 2
6464
```
6565

66-
This block defines a test job. The job will be executed by the container-runner-eiger-zen2.
67-
!!! todo
68-
link to runner
66+
This block defines a test job. The job will be executed by the [.container-runner-eiger-zen2](#container-runner).
6967

7068
This runner will pull the image on the cluster Eiger and run the commands as specified in the `script` tag. In this example we are requesting 2 nodes with 1 task on each node, i.e. 2 tasks total. All [Slurm environment variables](https://slurm.schedmd.com/srun.html#SECTION_INPUT-ENVIRONMENT-VARIABLES) are supported. The commands will be running inside the container specified by the `image` tag.
7169

0 commit comments

Comments
 (0)