Updated deprecated Slurm variable name #191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
preview available: https://docs.tds.cscs.ch/191 |
This comment was marked as off-topic.
This comment was marked as off-topic.
Collaborator
|
You can ignore the spell checker for now. I'm fixing typos and adding a bunch of words to the whitelist in separate PRs (e.g. #192). Bear with me for a moment... That said, if it points out a real typo, please do fix it 😉 (not the case here for the changes introduced here; it's checking the whole file that was changed though) |
Contributor
|
Thanks, confirming the change is necessary. Additionally, we'll need to pin the nanotron version and move the tutorials to a more visible place, but that can be done in a follow-up PR. |
lukasgd
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLURM_GPUS_PER_TASKseems to be deprecated on Alps. The current submission script fails because the variable is passed to torch as an empty string.SLURM_GPUS_ON_NODEreturns the proper number.