Skip to content

Add VASP documentation #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Apr 10, 2025
Merged

Add VASP documentation #79

merged 17 commits into from
Apr 10, 2025

Conversation

@AdhocMan
Copy link
Contributor

@AdhocMan AdhocMan commented Apr 8, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented Apr 8, 2025

preview available: https://docs.tds.cscs.ch/79

@github-actions
Copy link

github-actions bot commented Apr 8, 2025

preview available: https://docs.tds.cscs.ch/79

@AdhocMan AdhocMan marked this pull request as ready for review April 8, 2025 09:54
bcumming
bcumming requested changes Apr 8, 2025
View reviewed changes
Copy link
Member

@bcumming bcumming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the docs look good!

I have just a few suggestions.

RMeli
RMeli reviewed Apr 8, 2025
View reviewed changes
Copy link
Member

@RMeli RMeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AdhocMan, LGTM. Just a few nitpicks, most of which you can just accept/reject from the web UI.

@github-actions
Copy link

github-actions bot commented Apr 8, 2025

preview available: https://docs.tds.cscs.ch/79

1 similar comment
@github-actions
Copy link

github-actions bot commented Apr 8, 2025

preview available: https://docs.tds.cscs.ch/79

@github-actions
Copy link

github-actions bot commented Apr 8, 2025

preview available: https://docs.tds.cscs.ch/79

@github-actions
Copy link

github-actions bot commented Apr 8, 2025

preview available: https://docs.tds.cscs.ch/79

@github-actions
Copy link

github-actions bot commented Apr 8, 2025

preview available: https://docs.tds.cscs.ch/79

@github-actions
Copy link

github-actions bot commented Apr 8, 2025

preview available: https://docs.tds.cscs.ch/79

2 similar comments
@github-actions
Copy link

github-actions bot commented Apr 8, 2025

preview available: https://docs.tds.cscs.ch/79

@github-actions
Copy link

github-actions bot commented Apr 8, 2025

preview available: https://docs.tds.cscs.ch/79

@github-actions
Copy link

github-actions bot commented Apr 8, 2025

preview available: https://docs.tds.cscs.ch/79

@github-actions
Copy link

github-actions bot commented Apr 8, 2025

preview available: https://docs.tds.cscs.ch/79

@github-actions
Copy link

github-actions bot commented Apr 8, 2025

preview available: https://docs.tds.cscs.ch/79

@github-actions
Copy link

github-actions bot commented Apr 8, 2025

preview available: https://docs.tds.cscs.ch/79

1 similar comment
@github-actions
Copy link

github-actions bot commented Apr 8, 2025

preview available: https://docs.tds.cscs.ch/79

@AdhocMan
Copy link
Contributor Author

AdhocMan commented Apr 8, 2025

Thanks for the reviews!
It should be all addressed now.

@RMeli RMeli requested a review from bcumming April 8, 2025 15:35
@bcumming bcumming merged commit 4dd99e4 into eth-cscs:main Apr 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bcumming bcumming bcumming approved these changes

@RMeli RMeli RMeli approved these changes

@msimberg msimberg Awaiting requested review from msimberg msimberg is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AdhocMan @bcumming @RMeli