Skip to content

Commit f67e781

Browse files
committed
fix: 'get images' command now shows generic images to admin users
1 parent bd1f2c2 commit f67e781

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

src/cfs/session.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1337,7 +1337,7 @@ pub mod mesa {
13371337
/// 1) We extract the HSM groups the CFS session is linked to
13381338
/// 2) We substract the roles mentioned above to the list of HSM groups
13391339
/// 3) If the list is empty then, we are dealing with a generic CFS session
1340-
pub fn is_session_generic(cfs_session: &CfsSessionGetResponse) -> bool {
1340+
pub fn is_session_image_generic(cfs_session: &CfsSessionGetResponse) -> bool {
13411341
if cfs_session
13421342
.get_target_def()
13431343
.is_some_and(|target_def| target_def == "image".to_string())
@@ -1385,7 +1385,7 @@ pub mod mesa {
13851385
// hsm_group.members.ids
13861386
if !hsm_group_name_vec.is_empty() {
13871387
cfs_session_vec.retain(|cfs_session| {
1388-
(keep_generic_sessions && is_session_generic(cfs_session))
1388+
(keep_generic_sessions && is_session_image_generic(cfs_session))
13891389
|| cfs_session.get_target_hsm().is_some_and(|target_hsm_vec| {
13901390
target_hsm_vec
13911391
.iter()
@@ -1461,7 +1461,7 @@ pub mod mesa {
14611461
// hsm_group.members.ids
14621462
if !hsm_group_name_from_xnames_vec.is_empty() {
14631463
cfs_session_vec.retain(|cfs_session| {
1464-
(keep_generic_sessions && is_session_generic(cfs_session))
1464+
(keep_generic_sessions && is_session_image_generic(cfs_session))
14651465
|| cfs_session.get_target_hsm().is_some_and(|target_hsm_vec| {
14661466
target_hsm_vec.iter().any(|target_hsm| {
14671467
hsm_group_name_from_xnames_vec.contains(target_hsm)

src/ims/image/utils.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,8 @@ pub async fn filter(
110110
&mut cfs_session_vec,
111111
hsm_group_name_vec,
112112
None,
113-
false,
113+
crate::common::jwt_ops::is_user_admin(shasta_token).unwrap(),
114+
114115
)
115116
.await;
116117

0 commit comments

Comments
 (0)