Feedback from aiida-firecrest

[chrisjsewell]

Heya @ekouts just before I forget, as we just discussed, https://github.com/aiidateam/aiida-firecrest is now provisionally working with the latest version of pyfirecrest thanks 🎉

Feel free to have a look and provide any feedback.
A few notes (that I may add to later):

1. I am using an improved version of ✨ Add pathlib.Path interface #43 here: https://github.com/aiidateam/aiida-firecrest/blob/main/aiida_firecrest/remote_path.py, maybe this can eventually be upstreamed to here
2. I'm running the tests against a live instance of the firecrest demo server in Github CI: https://github.com/aiidateam/aiida-firecrest/blob/eb7f7518857794a99bae3568c74f0981b695dd79/.github/workflows/server-tests.yml
3. /utilities/upload can modify the requested filename (Very problematic 😅) firecrest#191 is currently the major block for production
4. The next major improvement is to look into improving large file transfers: Optimize file transfer aiidateam/aiida-firecrest#23

[ekouts]

Thanks a lot @chrisjsewell , your feedback is always useful!

(1) and (3): For the next weeks, we will prioritize eth-cscs/firecrest#191 and #43 .
(2) And running the tests against the demo server would be much easier than what I am currently doing so I will have a look.
(4) These are changes in the AiiDa side, correct?

[chrisjsewell]

These are changes in the AiiDa side, correct?

yep indeed, although there may eventually be something to upstream