don't allow empty --uenv='' or --uenv=[,]*

Author: simonpintarelli

ci/tests/test.bats

@@ -111,3 +111,13 @@ EOF
     run_srun_unchecked --uenv=a:b:c:/user-tools true
     assert_output --partial 'Invalid syntax for --uenv'
 }
+
+@test "empty_argument1" {
+    run_srun_unchecked --uenv='' true
+    assert_output --partial 'No mountpoints given.'
+}
+
+@test "empty_argument2" {
+    run_srun_unchecked --uenv=,,, true
+    assert_output --partial 'No mountpoints given.'
+}

src/parse_args.cpp

@@ -42,6 +42,10 @@ parse_arg(const std::string &arg) {
   std::vector<mount_entry> entries;
   std::vector<std::string> arguments = split(arg, ',');
 
+  if(arguments.empty()) {
+    return util::unexpected("No mountpoints given.");
+  }
+
   for (auto &entry : arguments) {
     std::smatch match_pieces;
     if (std::regex_match(entry, match_pieces, protocol_pattern)) {