remove todo

Author: drortirosh

packages/accounts/src/ambire/AmbireMultiChainSmartAccount.ts

@@ -97,15 +97,12 @@ export class AmbireMultiChainSmartAccount extends BaseMultichainSmartAccount {
     if (responses.length !== userOps.length) {
       throw new Error('AmbireMultiChainSmartAccount: signUserOps: number of responses does not match number of userOps')
     }
-    // TODO: Adjust the function return value to work with the defined APIs
     for (let i = 0; i < userOps.length; i++) {
       userOps[i] = responses[i].userOp
     }
     return userOps
   }
 
-  // TODO: I don't think this code is correct. The `calls` may contain a mix of Call and FunctionCall elements.
-  //       Must dispatch them to appropriate individual encode functions!
   async encodeCalls (chainId: bigint, calls: Array<Call | FunctionCall>): Promise<Hex> {
     const hasDynamic = calls.some((call) => isFunctionCall(call))
     if (hasDynamic) {
@@ -115,9 +112,6 @@ export class AmbireMultiChainSmartAccount extends BaseMultichainSmartAccount {
     }
   }
 
-  // TODO TODO: We don't actually need a 'viem SmartAccount' instance for Ambire wallet.
-  //      The Ambire wallet should handle everything - encoding, signing, broadcasting etc.
-  // generated
   private async createSmartAccountForChain (chainId: bigint, address: Address): Promise<SmartAccount> {
     const self = this
 

packages/sdk/src/sdk/account/BaseMultichainSmartAccount.ts

@@ -67,7 +67,6 @@ export abstract class BaseMultichainSmartAccount implements IMultiChainSmartAcco
     return this.bundlerManager.sendUserOperation(userOp)
   }
 
-  // TODO: this should only be done once - create an initializer function
   async verifyBundlerConfig (chainId: bigint, entryPoints: Address): Promise<void> {
     await this.bundlerManager.verifyConfig(chainId, entryPoints)
   }

packages/sdk/src/sdk/actions/VoucherRequestAction.ts

@@ -36,8 +36,6 @@ export class VoucherRequestAction implements BaseAction {
     const chainId = batch.chainId
 
     //add "approve" for each token we lock
-    // (TODO: do we want to allow the user to use "indefinite approval" ? it makes it slight cheaper, but requires
-    // us to check each token, if it already has approval or not)
     this.voucherRequest.tokens
       .filter(asset => toAddress(chainId, asset.token) !== NATIVE_ETH)
       .forEach(asset => {

packages/sdk/src/sdk/builder/BatchBuilder.ts

@@ -212,7 +212,6 @@ export class BatchBuilder {
       calls.length == 0 ? '0x' : this.smartAccount.encodeCalls(chainId, calls)
     ])
 
-    //TODO: get real basefee/priorityFee from network
     const { maxFeePerGas, maxPriorityFeePerGas } = await smartAccount.client.extend(publicActions).estimateFeesPerGas()
     let userOp = {
       chainId,
@@ -221,7 +220,6 @@ export class BatchBuilder {
       factory,
       factoryData,
       callData,
-      //TODO: calculate gas limits
       callGasLimit: 3000000n,
       verificationGasLimit: 500000n,
       preVerificationGas: 100000n,

packages/sdk/src/sdk/builder/CrossChainExecutor.ts

@@ -204,7 +204,6 @@ export class CrossChainExecutor {
         console.error('Error executing UserOperation:', e)
         // Validation failure during sending.
         // This indicates a potential issue with the UserOperation.
-        // TODO: Implement retry or cleanup logic here
         batchStatusInfo.status = OperationStatus.Failed
         batchStatusInfo.revertReason = e as any
         this.callCallback(CallbackType.Failed, callback, batchStatusInfo)
@@ -394,7 +393,6 @@ export class CrossChainExecutor {
       for (const outReq of op.batch.outVoucherRequests) {
         for (const nextOp of this.batchStatusInfos!) {
           if (nextOp.batch.inputVoucherRequests.some(inReq => outReq == inReq)) {
-            //TODO: need to push the request Ids depending on the actual destination chain
             if (!nextOp.requestIds) nextOp.requestIds = []
             // add requestIds related to this dest chain:
             for (const req of collected.requests ?? []) {
@@ -409,7 +407,6 @@ export class CrossChainExecutor {
       }
 
     } else {
-      //TODO: on-chain execution failed.
       // should trigger fallback actions
       op.status = OperationStatus.Failed
       this.callCallback(CallbackType.Failed, callback, op)
@@ -430,7 +427,6 @@ export class CrossChainExecutor {
       }
       await new Promise(resolve => setTimeout(resolve, 100))
     }
-    // TODO: throwing on timeout here is a bit too radical. This is a legitimate state we should handle.
     throw new Error('timeout: ' + this.timeoutSeconds)
   }
 

packages/sdk/src/sdk/types/IBundlerManager.ts

@@ -13,7 +13,6 @@ export interface SendRawUserOperationResponse {
 }
 
 export interface IBundlerManager {
-  // TODO: alexf: it is not clear why this method is needed, especially with these parameters
   verifyConfig (chainId: bigint, entrypoints: Address): Promise<void>
 
   sendUserOperation (userOp: UserOperation): Promise<Hex>

packages/sdk/src/sdk/types/MultichainClient.ts

@@ -21,7 +21,6 @@ export class MultichainClient {
     return Array.from(this.clients.values());
   }
 
-  //TODO: need a better way to configure all networks
   async addClient (client: PublicClient) {
     const chainId = BigInt(await client.getChainId())
     this.addClientWithChainId(client, chainId)