fix: Fixed issue where batching may have been used when it was not meant to be.

Signed-off-by: ethan-thompson <ethan.thompson@networkradius.com>

Author: ethan-thompson

src/modules/rlm_linelog/rlm_linelog.c

@@ -528,7 +528,6 @@ static xlat_action_t linelog_xlat(TALLOC_CTX *ctx, fr_dcursor_t *out,
 {
 	rlm_linelog_t const		*inst = talloc_get_type_abort_const(xctx->mctx->mi->data, rlm_linelog_t);
 	linelog_call_env_t const	*call_env = talloc_get_type_abort(xctx->env_data, linelog_call_env_t);
-	xlat_action_t 			ret;
 
 	struct iovec			vector[2];
 	size_t				i = 0;
@@ -556,7 +555,6 @@ static xlat_action_t linelog_xlat(TALLOC_CTX *ctx, fr_dcursor_t *out,
 			return XLAT_ACTION_FAIL;
 
 		case LINELOG_BUFFER_WRITE_DONE:
-			ret = XLAT_ACTION_DONE;
 			break;
 
 		case LINELOG_BUFFER_WRITE_YIELD:
@@ -566,7 +564,6 @@ static xlat_action_t linelog_xlat(TALLOC_CTX *ctx, fr_dcursor_t *out,
 		slen = entry->data_len;
 	} else {
 		slen = linelog_write(inst, call_env, request, vector, i, with_delim);
-		ret = XLAT_ACTION_DONE;
 	}
 
 	if (slen < 0) return XLAT_ACTION_FAIL;
@@ -576,7 +573,7 @@ static xlat_action_t linelog_xlat(TALLOC_CTX *ctx, fr_dcursor_t *out,
 
 	fr_dcursor_insert(out, wrote);
 
-	return ret;
+	return XLAT_ACTION_DONE;
 }
 
 typedef struct {
@@ -979,7 +976,7 @@ static int mod_instantiate(module_inst_ctx_t const *mctx)
 			}
 		}
 
-		if (inst->file.buffer_count != 0 || fr_time_delta_unwrap(inst->file.buffer_delay) != 0) {
+		if (inst->file.buffer_count != 0 || ((inst->file.buffer_delay_is_set) && (fr_time_delta_unwrap(inst->file.buffer_delay) != 0))) {
 			inst->file.buffer_write = true;
 
 			if (inst->file.buffer_delay_is_set && !inst->file.buffer_expiry_is_set) {