fix: Resolved a few issues where returns were not being checked or handled properly

Signed-off-by: ethan-thompson <ethan.thompson@networkradius.com>

Author: ethan-thompson

src/modules/rlm_linelog/file.c

@@ -249,16 +249,16 @@ static void _batch_write(rlm_linelog_file_t *file)
 	}
 
 done:
-	if (exfile_close(inst->file.ef, fd) < 0) {
+	if ((fd >= 0) && (exfile_close(inst->file.ef, fd) < 0)) {
 		PERROR("Failed closing file %s", file->filename);
 	}
 
 	fr_dbuff_reset_talloc(&file->dbuff);
 	file->entry_p = file->entry;
 
 	if (fr_time_delta_gt(inst->file.buffer_expiry, fr_time_delta_wrap(0))) {
-		fr_timer_in(file, file->thread_inst->tl, &file->expiry, inst->file.buffer_expiry,
-			    false, _batching_cleanup_timer, file);
+		MEM(fr_timer_in(file, file->thread_inst->tl, &file->expiry, inst->file.buffer_expiry,
+			    false, _batching_cleanup_timer, file));
 	}
 }
 
@@ -290,14 +290,20 @@ linelog_buffer_action_t file_enqueue_write(rlm_linelog_file_entry_t **entry_p, m
 
 		file->filename = talloc_strdup(file, path);
 		file->log_header = fr_value_box_alloc_null(file);
+
+		if (unlikely(!file->log_header)) {
+			RPERROR("Failed to allocate log header for buffered log file %pV", call_env->filename);
+		error:
+			talloc_free(file);
+			return LINELOG_BUFFER_WRITE_FAIL;
+		}
+
 		file->mod_inst = inst;
 		file->thread_inst = thread;
 
 		if (call_env->log_head && fr_value_box_copy(file, file->log_header, call_env->log_head) < 0) {
 			RPERROR("Failed to copy log header for buffered log file %pV", call_env->filename);
-		error:
-			talloc_free(file);
-			return LINELOG_BUFFER_WRITE_FAIL;
+			goto error;
 		}
 
 		file->entry_p = file->entry;
@@ -337,8 +343,12 @@ linelog_buffer_action_t file_enqueue_write(rlm_linelog_file_entry_t **entry_p, m
 	*entry_p = file->entry_p;
 
 	if (fr_time_delta_gt(inst->file.buffer_delay, fr_time_delta_wrap(0)) && !fr_timer_armed(file->write) ) {
-		fr_timer_in(file, file->thread_inst->tl, &file->write, inst->file.buffer_delay,
-			    false, _batching_handle_timeout, file);
+		if (fr_timer_in(file, file->thread_inst->tl, &file->write, inst->file.buffer_delay,
+			    false, _batching_handle_timeout, file)) {
+			RPERROR("Failed to insert timer for buffered log file %pV", call_env->filename);
+			file->entry_p->failed = true;
+			return LINELOG_BUFFER_WRITE_FAIL;
+		}
 	}
 
 	file->entry_p->data_len = ret;