Skip to content

Commit 26da0df

Browse files
committed
update cran-comments, etc
1 parent 26afa4d commit 26da0df

File tree

5 files changed

+17
-18
lines changed

5 files changed

+17
-18
lines changed

.Rbuildignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
^\.Rhistory$
88
^.Rproj*$
99
[.]DS_Store$
10+
^\.DS_Store$
1011
^CRAN-SUBMISSION$
1112
^cran-comments.md
1213
^_pkgdown\.yml$

NEWS.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ toggle scaling of chromatograms resolving ([#30](https://github.com/ethanbass/ch
139139

140140
### Other Improvements
141141

142-
* Improved automatic filetype detection by `read_chroms`.
142+
* Improved automatic file type detection by `read_chroms`.
143143
* Refactored `read_thermoraw` function to simplify paths.
144144
* The `thermoraw` and `openchrom` parsers now use a proper temp directory if an export directory is not specified through the `path_out` argument.
145145
* Re-factored `reshape_chroms`, speeding up conversion from wide to long format.

R/read_peaklist.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
#'
33
#' Reads peak lists from specified folders or vector of paths.
44
#'
5-
#' @param paths Paths to files or folders containing peaklist files.
5+
#' @param paths Paths to files or folders containing peak list files.
66
#' @param find_files Logical. Set to \code{TRUE} (default) if you are providing
77
#' the function with a folder or vector of folders containing the files.
88
#' Otherwise, set to\code{FALSE}.

cran-comments.md

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,21 @@
1-
## Response to comments
2-
3-
I've added single quotes around proper nouns in the package description, as requested by Uwe Ligges and pushed the version to 0.2.1. Thanks!
4-
51
## R CMD check results
2+
63
There were no ERRORs or WARNINGs.
74

8-
There were 2 NOTES:
5+
There were up to 2 NOTES (depending on the system where the package was checked):
6+
7+
* Possibly misspelled words in DESCRIPTION:
8+
chromConverter (19:42)
99

1010
* Suggests or Enhances not in mainstream repositories:
11-
entab
11+
entab, chromConverterExtraTests
1212
Availability using Additional_repositories specification:
13-
entab yes https://ethanbass.github.io/drat/
13+
entab yes https://ethanbass.github.io/drat/
14+
chromConverterExtraTests yes https://ethanbass.github.io/drat/
15+
? ? https://ethanbass.r-universe.dev/
16+
17+
Uses the non-portable package: ‘mzR’
1418

15-
Entab is suggested but not required. It can be downloaded from my drat repository or from its official github page https://github.com/bovee/entab.
19+
"chromConverter"" is the name of the package and is not mis-spelled.
1620

17-
* Found the following (possibly) invalid URLs:
18-
URL: https://doi.org/10.1021/acs.jproteome.9b00328
19-
From: man/read_thermoraw.Rd
20-
Status: 503
21-
Message: Service Unavailable
22-
23-
The URL in question appears to be perfectly valid. At least it loads in the web browser just fine.
21+
Entab, mzR, and chromConverterExtraTests are not required. The Entab and chromConverterExtraTests packages can be installed from my drat repository or from my r-universe repository.

man/read_peaklist.Rd

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)