Skip to content

Commit 43dae4c

Browse files
committed
Changeset: Delete unused index parameters in applyZip()
1 parent b321599 commit 43dae4c

File tree

1 file changed

+7
-9
lines changed

1 file changed

+7
-9
lines changed

src/static/js/Changeset.js

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -986,9 +986,7 @@ exports.textLinesMutator = (lines) => {
986986
* Apply operations to other operations.
987987
*
988988
* @param {string} in1 - first Op string
989-
* @param {number} idx1 - integer where 1st iterator should start
990989
* @param {string} in2 - second Op string
991-
* @param {number} idx2 - integer where 2nd iterator should start
992990
* @param {Function} func - Callback that applies an operation to another operation. Will be called
993991
* multiple times depending on the number of operations in `in1` and `in2`. `func` has signature
994992
* `f(op1, op2, opOut)`:
@@ -1005,9 +1003,9 @@ exports.textLinesMutator = (lines) => {
10051003
* other out), `opOut.opcode` MUST be set to the empty string.
10061004
* @returns {string} the integrated changeset
10071005
*/
1008-
exports.applyZip = (in1, idx1, in2, idx2, func) => {
1009-
const iter1 = exports.opIterator(in1, idx1);
1010-
const iter2 = exports.opIterator(in2, idx2);
1006+
exports.applyZip = (in1, in2, func) => {
1007+
const iter1 = exports.opIterator(in1);
1008+
const iter2 = exports.opIterator(in2);
10111009
const assem = exports.smartOpAssembler();
10121010
const op1 = exports.newOp();
10131011
const op2 = exports.newOp();
@@ -1315,7 +1313,7 @@ exports._slicerZipperFunc = (attOp, csOp, opOut, pool) => {
13151313
exports.applyToAttribution = (cs, astr, pool) => {
13161314
const unpacked = exports.unpack(cs);
13171315

1318-
return exports.applyZip(astr, 0, unpacked.ops, 0,
1316+
return exports.applyZip(astr, unpacked.ops,
13191317
(op1, op2, opOut) => exports._slicerZipperFunc(op1, op2, opOut, pool));
13201318
};
13211319

@@ -1486,7 +1484,7 @@ exports.compose = (cs1, cs2, pool) => {
14861484
const bankIter2 = exports.stringIterator(unpacked2.charBank);
14871485
const bankAssem = exports.stringAssembler();
14881486

1489-
const newOps = exports.applyZip(unpacked1.ops, 0, unpacked2.ops, 0, (op1, op2, opOut) => {
1487+
const newOps = exports.applyZip(unpacked1.ops, unpacked2.ops, (op1, op2, opOut) => {
14901488
const op1code = op1.opcode;
14911489
const op2code = op2.opcode;
14921490
if (op1code === '+' && op2code === '-') {
@@ -2265,7 +2263,7 @@ exports.follow = (cs1, cs2, reverseInsertOrder, pool) => {
22652263

22662264
const hasInsertFirst = exports.attributeTester(['insertorder', 'first'], pool);
22672265

2268-
const newOps = exports.applyZip(unpacked1.ops, 0, unpacked2.ops, 0, (op1, op2, opOut) => {
2266+
const newOps = exports.applyZip(unpacked1.ops, unpacked2.ops, (op1, op2, opOut) => {
22692267
if (op1.opcode === '+' || op2.opcode === '+') {
22702268
let whichToDo;
22712269
if (op2.opcode !== '+') {
@@ -2437,7 +2435,7 @@ exports.composeWithDeletions = (cs1, cs2, pool) => {
24372435
const bankIter2 = exports.stringIterator(unpacked2.charBank);
24382436
const bankAssem = exports.stringAssembler();
24392437

2440-
const newOps = exports.applyZip(unpacked1.ops, 0, unpacked2.ops, 0, (op1, op2, opOut) => {
2438+
const newOps = exports.applyZip(unpacked1.ops, unpacked2.ops, (op1, op2, opOut) => {
24412439
const op1code = op1.opcode;
24422440
const op2code = op2.opcode;
24432441
if (op1code === '+' && op2code === '-') {

0 commit comments

Comments
 (0)