Skip to content

Commit 4808041

Browse files
TommyTran732rhansen
authored andcommitted
Docker: Update to the latest LTS image
The Node.js 14 slim image has quite a few vulnerabilities, and I have tested the latest slim image. It works just fine. When installing plugins, `--legacy-peer-deps` is passed to npm because npm v7 (which comes with Node.js v16, the current LTS) changed how peer deps are handled. The new behavior is incompatible with how plugins have historically been installed.
1 parent a02e454 commit 4808041

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
#
55
# Author: muxator
66

7-
FROM node:14-buster-slim
7+
FROM node:lts-slim
88
LABEL maintainer="Etherpad team, https://github.com/ether/etherpad-lite"
99

1010
# plugins to install while building the container. By default no plugins are
@@ -85,7 +85,7 @@ COPY --chown=etherpad:etherpad ./ ./
8585
# seems to confuse tools such as `npm outdated`, `npm update`, and some ESLint
8686
# rules.
8787
RUN { [ -z "${ETHERPAD_PLUGINS}" ] || \
88-
npm install --no-save ${ETHERPAD_PLUGINS}; } && \
88+
npm install --no-save --legacy-peer-deps ${ETHERPAD_PLUGINS}; } && \
8989
src/bin/installDeps.sh && \
9090
rm -rf ~/.npm
9191

0 commit comments

Comments
 (0)