fix(test): auto-dismiss deletion-token modal in goToNewPad helper

The token modal introduced in PR1 blocks clicks for every Playwright
test that creates a new pad via the shared helper. Add a one-line
dismissal so unrelated tests keep passing, and have the deletion-token
spec navigate inline via newPadKeepingModal() when it needs the modal
open to capture the token.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: JohnMcLear

src/tests/frontend-new/helper/padHelper.ts

@@ -120,6 +120,14 @@ export const goToNewPad = async (page: Page) => {
   await page.goto('http://localhost:9001/p/'+padId);
   await page.waitForSelector('iframe[name="ace_outer"]');
   await page.waitForSelector('#editorcontainer.initialized');
+  // Creator sessions see the one-time pad-deletion-token modal on first visit.
+  // Dismiss it so subsequent clicks in generic tests are not blocked. Tests
+  // that need to interact with the modal should navigate to a new pad inline
+  // instead of using this helper.
+  const tokenModal = page.locator('#deletiontoken-modal');
+  if (await tokenModal.isVisible().catch(() => false)) {
+    await page.locator('#deletiontoken-ack').click();
+  }
   return padId;
 }
 

src/tests/frontend-new/specs/pad_deletion_token.spec.ts

@@ -1,14 +1,26 @@
-import {expect, test} from '@playwright/test';
-import {goToNewPad, goToPad} from '../helper/padHelper';
+import {expect, test, Page} from '@playwright/test';
+import {randomUUID} from 'node:crypto';
+import {goToPad} from '../helper/padHelper';
 import {showSettings} from '../helper/settingsHelper';
 
+// goToNewPad() in the shared helper auto-dismisses the deletion-token modal
+// so unrelated tests aren't blocked. These tests need the modal, so they
+// navigate inline without the helper.
+const newPadKeepingModal = async (page: Page) => {
+  const padId = `FRONTEND_TESTS${randomUUID()}`;
+  await page.goto(`http://localhost:9001/p/${padId}`);
+  await page.waitForSelector('iframe[name="ace_outer"]');
+  await page.waitForSelector('#editorcontainer.initialized');
+  return padId;
+};
+
 test.describe('pad deletion token', () => {
   test.beforeEach(async ({context}) => {
     await context.clearCookies();
   });
 
   test('creator sees a token modal exactly once and can dismiss it', async ({page}) => {
-    await goToNewPad(page);
+    await newPadKeepingModal(page);
     const modal = page.locator('#deletiontoken-modal');
     await expect(modal).toBeVisible();
 
@@ -24,7 +36,7 @@ test.describe('pad deletion token', () => {
   });
 
   test('second device can delete using the captured token', async ({page, browser}) => {
-    const padId = await goToNewPad(page);
+    const padId = await newPadKeepingModal(page);
     const token = await page.locator('#deletiontoken-value').inputValue();
     await page.locator('#deletiontoken-ack').click();
 
@@ -45,7 +57,7 @@ test.describe('pad deletion token', () => {
   });
 
   test('wrong token keeps the pad alive and surfaces a shout', async ({page, browser}) => {
-    const padId = await goToNewPad(page);
+    const padId = await newPadKeepingModal(page);
     await page.locator('#deletiontoken-ack').click();
 
     const context2 = await browser.newContext();
@@ -55,7 +67,6 @@ test.describe('pad deletion token', () => {
 
     await page2.locator('#delete-pad-with-token > summary').click();
     await page2.locator('#delete-pad-token-input').fill('bogus-token-value');
-    // Accept the confirm() dialog, then capture the alert() the shout triggers.
     const dialogs: string[] = [];
     page2.on('dialog', async (d) => {
       dialogs.push(d.message());
@@ -66,7 +77,6 @@ test.describe('pad deletion token', () => {
     await expect.poll(() => dialogs.length, {timeout: 10000}).toBeGreaterThanOrEqual(2);
     expect(dialogs.some((m) => /not the creator|cannot delete/i.test(m))).toBe(true);
 
-    // Pad must still exist for the original creator.
     await page.reload();
     await expect(page.locator('#editorcontainer.initialized')).toBeVisible();
     await context2.close();