fix(editor): auto-hide menu_right on readonly pads, accept showMenuRight=true override

Addresses Qodo review feedback on #7553:

1. Readonly pads now hide the right-side toolbar automatically. The
   original issue (#5182) was specifically about readonly embeds; the
   previous implementation only honoured an explicit `?showMenuRight=false`
   URL parameter, which meant that vanilla readonly pads still showed
   import/export/timeslider/settings/share/users controls — all noise
   for viewers who can't interact with the pad anyway.

2. Callers who still want the menu visible on readonly pads can opt
   back in with `?showMenuRight=true`. The URL-param callback now
   accepts both values instead of just `false`.

3. The Playwright spec's `browser.newContext() + clearCookies()` pattern
   was a no-op because the test navigated with the existing `page`
   fixture (different context). Switch to `page.context().clearCookies()`,
   and cover both the auto-hide and the explicit-override paths on a
   readonly-URL navigation.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: JohnMcLear

src/static/js/pad.ts

@@ -77,10 +77,19 @@ const getParameters = [
     },
   },
   {
+    // showMenuRight accepts 'true' or 'false'. Explicit 'false' hides the
+    // right-side toolbar (import/export/timeslider/settings/share/users);
+    // explicit 'true' forces it visible, overriding the readonly
+    // auto-hide applied further down (issue #5182). Any other value is
+    // a no-op — the menu stays in its default state.
     name: 'showMenuRight',
-    checkVal: 'false',
+    checkVal: null,
     callback: (val) => {
-      $('#editbar .menu_right').hide();
+      if (val === 'false') {
+        $('#editbar .menu_right').hide();
+      } else if (val === 'true') {
+        $('#editbar .menu_right').show();
+      }
     },
   },
   {
@@ -685,6 +694,14 @@ const pad = {
       $('#chaticon').hide();
       $('#options-chatandusers').parent().hide();
       $('#options-stickychat').parent().hide();
+      // Hide the right-side toolbar on readonly pads — import/export,
+      // timeslider, settings, share, users are all noise for viewers
+      // who can't interact with the pad. Callers who need those
+      // controls visible on a readonly pad can force them back via
+      // `?showMenuRight=true`, which runs in getParameters() above.
+      if (getUrlVars().get('showMenuRight') !== 'true') {
+        $('#editbar .menu_right').hide();
+      }
     } else if (!settings.hideChat) { $('#chaticon').show(); }
 
     $('body').addClass(window.clientVars.readonly ? 'readonly' : 'readwrite');

src/tests/frontend-new/specs/hide_menu_right.spec.ts

@@ -1,9 +1,11 @@
 import {expect, test} from "@playwright/test";
 import {appendQueryParams, goToNewPad} from "../helper/padHelper";
 
-test.beforeEach(async ({page, browser}) => {
-  const context = await browser.newContext();
-  await context.clearCookies();
+test.beforeEach(async ({page}) => {
+  // clearCookies on the page's own context — creating a separate
+  // BrowserContext and clearing cookies on it is a no-op for the page
+  // fixture (Qodo review feedback on #7553).
+  await page.context().clearCookies();
   await goToNewPad(page);
 });
 
@@ -19,8 +21,26 @@ test.describe('showMenuRight URL parameter', function () {
     await expect(page.locator('#editbar .menu_left')).toBeVisible();
   });
 
-  test('showMenuRight with any other value leaves .menu_right visible', async function ({page}) {
+  test('showMenuRight=true keeps .menu_right visible', async function ({page}) {
     await appendQueryParams(page, {showMenuRight: 'true'});
     await expect(page.locator('#editbar .menu_right')).toBeVisible();
   });
+
+  test('readonly pad hides .menu_right by default', async function ({page}) {
+    // Find the share link which exposes the readonly r.* id, then navigate.
+    await page.locator('.buttonicon-embed').click();
+    const readonlyUrl = await page.locator('#readonlyInput').inputValue();
+    expect(readonlyUrl).toMatch(/\/p\/r\./);
+    await page.goto(readonlyUrl);
+    await page.waitForSelector('#editorcontainer.initialized');
+    await expect(page.locator('#editbar .menu_right')).toBeHidden();
+  });
+
+  test('readonly pad with showMenuRight=true keeps the menu visible', async function ({page}) {
+    await page.locator('.buttonicon-embed').click();
+    const readonlyUrl = await page.locator('#readonlyInput').inputValue();
+    await page.goto(`${readonlyUrl}?showMenuRight=true`);
+    await page.waitForSelector('#editorcontainer.initialized');
+    await expect(page.locator('#editbar .menu_right')).toBeVisible();
+  });
 });