Skip to content

Commit 3299f2c

Browse files
committed
Resolve lint issues for rvgol and rvsol
1 parent cb5e8b2 commit 3299f2c

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

op-e2e/e2eutils/disputegame/output_asterisc_helper.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ func (g *OutputAsteriscGameHelper) CreateHonestActor(ctx context.Context, l2Node
7777
prestateProvider := outputs.NewPrestateProvider(rollupClient, actorCfg.PrestateBlock)
7878
l1Head := g.GetL1Head(ctx)
7979
accessor, err := outputs.NewOutputAsteriscTraceAccessor(
80-
logger, metrics.NoopMetrics, cfg.Asterisc, vm.NewOpProgramServerExecutor(), l2Client, prestateProvider, cfg.AsteriscAbsolutePreState, rollupClient, dir, l1Head, splitDepth, actorCfg.PrestateBlock, actorCfg.PoststateBlock)
80+
logger, metrics.NoopMetrics, cfg.Asterisc, vm.NewOpProgramServerExecutor(logger), l2Client, prestateProvider, cfg.AsteriscAbsolutePreState, rollupClient, dir, l1Head, splitDepth, actorCfg.PrestateBlock, actorCfg.PoststateBlock)
8181
g.Require.NoError(err, "Failed to create output asterisc trace accessor")
8282
return op_e2e_disputegame.NewOutputHonestHelper(g.T, g.Require, &g.OutputGameHelper, g.Game, accessor)
8383
}
@@ -279,7 +279,7 @@ func (g *OutputAsteriscGameHelper) createAsteriscTraceProvider(ctx context.Conte
279279
localContext = outputs.CreateLocalContext(pre, post)
280280
dir := filepath.Join(cfg.Datadir, "asterisc-trace")
281281
subdir := filepath.Join(dir, localContext.Hex())
282-
return asterisc.NewTraceProviderForTest(logger, metrics.NoopMetrics.VmMetrics(types.TraceTypeAsterisc.String()), cfg, localInputs, subdir, g.MaxDepth(ctx)-splitDepth-1), nil
282+
return asterisc.NewTraceProviderForTest(logger, metrics.NoopMetrics.ToTypedVmMetrics(types.TraceTypeAsterisc.String()), cfg, localInputs, subdir, g.MaxDepth(ctx)-splitDepth-1), nil
283283
})
284284

285285
claims, err := g.Game.GetAllClaims(ctx, rpcblock.Latest)

op-e2e/faultproofs/precompile_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -262,7 +262,7 @@ func runAsterisc(t *testing.T, ctx context.Context, sys *e2esys.System, inputs u
262262
asteriscOpts(&cfg)
263263

264264
logger := testlog.Logger(t, log.LevelInfo).New("role", "asterisc")
265-
executor := vm.NewExecutor(logger, metrics.NoopMetrics.VmMetrics("asterisc"), cfg.Asterisc, vm.NewOpProgramServerExecutor(), cfg.AsteriscAbsolutePreState, inputs)
265+
executor := vm.NewExecutor(logger, metrics.NoopMetrics.ToTypedVmMetrics("asterisc"), cfg.Asterisc, vm.NewOpProgramServerExecutor(logger), cfg.AsteriscAbsolutePreState, inputs)
266266

267267
t.Log("Running asterisc")
268268
err := executor.DoGenerateProof(ctx, proofsDir, math.MaxUint, math.MaxUint, extraVmArgs...)

rvsol/src/RISCV.sol

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1129,10 +1129,10 @@ contract RISCV is IBigStepper {
11291129
// futex - not supported, for now
11301130
revertWithCode(0xf001ca11) // unsupported system call
11311131
}
1132-
// case 101 {
1133-
// // nanosleep - not supported, for now
1134-
// revertWithCode(0xf001ca11) // unsupported system call
1135-
// }
1132+
// case 101 {
1133+
// // nanosleep - not supported, for now
1134+
// revertWithCode(0xf001ca11) // unsupported system call
1135+
// }
11361136
default {
11371137
// Ignore(no-op) unsupported system calls
11381138
setRegister(toU64(10), toU64(0))

0 commit comments

Comments
 (0)