txpool: Use CrossUnsafe for Interop Ingress Filter (#428)

axelKingsley · web-flow · commit 0251cf7da4a2 · 2025-02-06T18:21:24.000+01:00
diff --git a/core/txpool/ingress_filters.go b/core/txpool/ingress_filters.go
@@ -53,5 +53,7 @@ func (f *interopFilter) FilterTx(ctx context.Context, tx *types.Transaction) boo
 	ctx, cancel := context.WithTimeout(ctx, time.Second*2)
 	defer cancel()
 	// check with the supervisor if the transaction should be allowed given the executing messages
-	return f.checkFn(ctx, ems, interoptypes.Unsafe) == nil
+	// the message can be unsafe (discovered only via P2P unsafe blocks), but it must be cross-valid
+	// so CrossUnsafe is used here
+	return f.checkFn(ctx, ems, interoptypes.CrossUnsafe) == nil
 }

Original file line number	Diff line number	Diff line change
`@@ -53,5 +53,7 @@ func (f interopFilter) FilterTx(ctx context.Context, tx types.Transaction) boo`
`53`	`53`	`ctx, cancel := context.WithTimeout(ctx, time.Second*2)`
`54`	`54`	`defer cancel()`
`55`	`55`	`// check with the supervisor if the transaction should be allowed given the executing messages`
`56`		`- return f.checkFn(ctx, ems, interoptypes.Unsafe) == nil`
	`56`	`+ // the message can be unsafe (discovered only via P2P unsafe blocks), but it must be cross-valid`
	`57`	`+ // so CrossUnsafe is used here`
	`58`	`+ return f.checkFn(ctx, ems, interoptypes.CrossUnsafe) == nil`
`57`	`59`	`}`