eth/catalyst: fail on duplicate request types (#31071)

s1na · sebastianst · commit 3af2fda49824 · 2025-01-27T14:17:55.000+01:00
Refer to: ethereum/execution-apis#623
diff --git a/eth/catalyst/api.go b/eth/catalyst/api.go
@@ -1347,7 +1347,8 @@ func validateRequests(requests [][]byte) error {
 			return fmt.Errorf("empty request: %v", req)
 		}
 		// Check that requests are ordered by their type.
-		if req[0] < last {
+		// Each type must appear only once.
+		if req[0] <= last {
 			return fmt.Errorf("invalid request order: %v", req)
 		}
 		last = req[0]

Original file line number	Diff line number	Diff line change
`@@ -1347,7 +1347,8 @@ func validateRequests(requests [][]byte) error {`
`1347`	`1347`	`return fmt.Errorf("empty request: %v", req)`
`1348`	`1348`	`}`
`1349`	`1349`	`// Check that requests are ordered by their type.`
`1350`		`- if req[0] < last {`
	`1350`	`+ // Each type must appear only once.`
	`1351`	`+ if req[0] <= last {`
`1351`	`1352`	`return fmt.Errorf("invalid request order: %v", req)`
`1352`	`1353`	`}`
`1353`	`1354`	`last = req[0]`