Skip to content

Commit 3be6a51

Browse files
make isGameProper comment more obvious
1 parent e86a520 commit 3be6a51

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

packages/contracts-bedrock/snapshots/semver-lock.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@
153153
},
154154
"src/dispute/AnchorStateRegistry.sol": {
155155
"initCodeHash": "0x00a96ace2161b2ede09cf2082d934fe60769c0120c34d61a22a953e8d6a32860",
156-
"sourceCodeHash": "0xe3925207ad74934375a0b411082f09238a5023b359c08af01c4f765225797068"
156+
"sourceCodeHash": "0xde0d10f630e7a8911e43ea6a8545f9d1767ae356469d2a2eabbdcb029b8659d9"
157157
},
158158
"src/dispute/DelayedWETH.sol": {
159159
"initCodeHash": "0x759d7f9c52b7c13ce4502f39dae3a75d130c6278240cde0b60ae84616aa2bd48",

packages/contracts-bedrock/src/dispute/AnchorStateRegistry.sol

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,9 +131,11 @@ contract AnchorStateRegistry is Initializable, ISemver {
131131
return _game.createdAt().raw() < portal.respectedGameTypeUpdatedAt();
132132
}
133133

134-
/// @notice Determines whether a game resolved properly and the game was not subject to any
134+
/// @notice **READ THIS FUNCTION DOCUMENTATION CAREFULLY.**
135+
/// Determines whether a game resolved properly and the game was not subject to any
135136
/// invalidation conditions. The root claim of a proper game IS NOT guaranteed to be
136137
/// valid. The root claim of a proper game CAN BE incorrect and still be a proper game.
138+
/// DO NOT USE THIS FUNCTION ALONE TO DETERMINE IF A ROOT CLAIM IS VALID.
137139
/// @param _game The game to check.
138140
/// @return Whether the game is a proper game.
139141
/// @return Reason why the game is not a proper game.
@@ -152,7 +154,7 @@ contract AnchorStateRegistry is Initializable, ISemver {
152154
return (false, "game blacklisted");
153155
}
154156

155-
// Must be created after the gameRetirementTimestamp.
157+
// Must be created at or after the respectedGameTypeUpdatedAt timestamp.
156158
if (isGameRetired(_game)) {
157159
return (false, "game retired");
158160
}

0 commit comments

Comments
 (0)