opcm: Update upgrade method for disputegame-v2 (#17874)

* opcm: Update upgrade method for disputegame-v2

* update opcm semver

* check game args; run post-upgrade checks

* update std validator semver lock

* fix assertGameArgsLength error prefix

* opcm and validator fixes

* lint LibGameArgs

* fix interfaces; natspec

* fix natspec in opcm

* forwards-compatible challenger/proposer retrieval

* assert deployed CANNON game parameters

* use v2 getters

* review comments

* fix asr getter name

* use v1 functions for existing upgrade path

Author: Inphi

packages/contracts-bedrock/interfaces/L1/IOPContractsManagerStandardValidator.sol

@@ -34,6 +34,8 @@ interface IOPContractsManagerStandardValidator {
         address challenger;
     }
 
+    error InvalidGameArgsLength();
+
     function version() external view returns (string memory);
     function anchorStateRegistryImpl() external view returns (address);
     function challenger() external view returns (address);

packages/contracts-bedrock/snapshots/abi/OPContractsManagerStandardValidator.json

@@ -289,7 +289,7 @@
         "type": "string"
       }
     ],
-    "stateMutability": "pure",
+    "stateMutability": "view",
     "type": "function"
   },
   {
@@ -465,5 +465,10 @@
     ],
     "stateMutability": "view",
     "type": "function"
+  },
+  {
+    "inputs": [],
+    "name": "InvalidGameArgsLength",
+    "type": "error"
   }
 ]

packages/contracts-bedrock/snapshots/abi/OPContractsManagerUpgrader.json

@@ -366,6 +366,22 @@
     "name": "IdentityPrecompileCallFailed",
     "type": "error"
   },
+  {
+    "inputs": [
+      {
+        "internalType": "bytes32",
+        "name": "devFeature",
+        "type": "bytes32"
+      }
+    ],
+    "name": "InvalidDevFeatureAccess",
+    "type": "error"
+  },
+  {
+    "inputs": [],
+    "name": "InvalidGameArgsLength",
+    "type": "error"
+  },
   {
     "inputs": [],
     "name": "NotABlueprint",

packages/contracts-bedrock/snapshots/semver-lock.json

@@ -20,12 +20,12 @@
     "sourceCodeHash": "0xfca613b5d055ffc4c3cbccb0773ddb9030abedc1aa6508c9e2e7727cc0cd617b"
   },
   "src/L1/OPContractsManager.sol:OPContractsManager": {
-    "initCodeHash": "0x4025118658a1c56c4fc2d0166081e6d27da980318e749e7811c7178115e4413e",
-    "sourceCodeHash": "0xdb243ac7475b0214b8f662aa04f696d9ff213dade6b1bdade379e84df419b75a"
+    "initCodeHash": "0xc6a5146f158bc14297447cda1668f83e8dbfdd74f1b8bc2291d9626933bd23ad",
+    "sourceCodeHash": "0xd883ebfcc637ba9c6de12a872015098614cd288aaee84cda9d4c746aa1dcba18"
   },
   "src/L1/OPContractsManagerStandardValidator.sol:OPContractsManagerStandardValidator": {
-    "initCodeHash": "0x57d6a6729d887ead009d518e8f17fa0d26bfc97b8efe1494ab4ef8dbb000d109",
-    "sourceCodeHash": "0x1d58891954cf782d2fe4f112b0c7fd25be991c2b8873f10d8545c653b517cac9"
+    "initCodeHash": "0x2eaa345ba05582c67b40a1eb7ec9d54823aa08468e697e2d6c04bb74cc574abc",
+    "sourceCodeHash": "0x30d7e4243a3bab7fea8504be2cd24f2c5ab3335b802d62282a374a458a08feec"
   },
   "src/L1/OptimismPortal2.sol:OptimismPortal2": {
     "initCodeHash": "0x5bf576ea7f566e402a997204988471fc9b971410aa9dff8fe810b10baf6b7456",