op-challenger: Support retrieving the oracle and prestate via game args. (#17958)

The implementation contract doesn't always have the values embedded.

Author: ajsutton

op-acceptance-tests/tests/base/disputegame_v2/init_test.go

@@ -7,7 +7,5 @@ import (
 )
 
 func TestMain(m *testing.M) {
-	// TODO(#17810): Use the new v2 dispute game flag via presets.WithDisputeGameV2()
-	//presets.DoMain(m, presets.WithProofs(), presets.WithDisputeGameV2())
-	presets.DoMain(m, presets.WithProofs())
+	presets.DoMain(m, presets.WithProofs(), presets.WithDisputeGameV2())
 }

op-acceptance-tests/tests/base/disputegame_v2/smoke_test.go

@@ -3,22 +3,27 @@ package disputegame_v2
 import (
 	"testing"
 
+	"github.com/ethereum-optimism/optimism/op-challenger/game/fault/contracts/gameargs"
 	challengerTypes "github.com/ethereum-optimism/optimism/op-challenger/game/fault/types"
 	"github.com/ethereum-optimism/optimism/op-devstack/devtest"
 	"github.com/ethereum-optimism/optimism/op-devstack/presets"
 )
 
 func TestSmoke(gt *testing.T) {
-	gt.Skip("TODO(#17810): Re-enable once opcm.deploy supports v2 dispute games")
 	t := devtest.SerialT(gt)
 	sys := presets.NewMinimal(t)
 	require := t.Require()
 	dgf := sys.DisputeGameFactory()
 
 	gameArgs := dgf.GameArgs(challengerTypes.PermissionedGameType)
 	require.NotEmpty(gameArgs, "game args is must be set for permissioned v2 dispute games")
+	_, err := gameargs.Parse(gameArgs)
+	require.NoError(err, "Permissioned game args invalid")
+
 	gameArgs = dgf.GameArgs(challengerTypes.CannonGameType)
 	require.NotEmpty(gameArgs, "game args is must be set for cannon v2 dispute games")
+	_, err = gameargs.Parse(gameArgs)
+	require.NoError(err, "Permissionless game args invalid")
 
 	permissionedGame := dgf.GameImpl(challengerTypes.PermissionedGameType)
 	require.NotEmpty(permissionedGame.Address, "permissioned game impl must be set")

op-chain-ops/cmd/unclaimed-credits/main.go

@@ -72,7 +72,10 @@ func unclaimedCreditsApp(ctx *cli.Context) error {
 	defer l1Client.Close()
 
 	caller := batching.NewMultiCaller(l1Client.Client(), batching.DefaultBatchSize)
-	contract := contracts.NewDisputeGameFactoryContract(metrics.NoopContractMetrics, factoryAddr, caller)
+	contract, err := contracts.NewDisputeGameFactoryContract(ctx.Context, metrics.NoopContractMetrics, factoryAddr, caller)
+	if err != nil {
+		return fmt.Errorf("failed to create dispute game factory contract: %w", err)
+	}
 	head, err := l1Client.HeaderByNumber(ctx.Context, nil)
 	if err != nil {
 		return fmt.Errorf("failed to retrieve current head block: %w", err)

op-challenger/cmd/create_game.go

@@ -43,7 +43,7 @@ func CreateGame(ctx *cli.Context) error {
 
 	contract, txMgr, err := NewContractWithTxMgr[*contracts.DisputeGameFactoryContract](ctx, flags.FactoryAddress,
 		func(ctx context.Context, metricer contractMetrics.ContractMetricer, address common.Address, caller *batching.MultiCaller) (*contracts.DisputeGameFactoryContract, error) {
-			return contracts.NewDisputeGameFactoryContract(metricer, address, caller), nil
+			return contracts.NewDisputeGameFactoryContract(ctx, metricer, address, caller)
 		})
 	if err != nil {
 		return fmt.Errorf("failed to create dispute game factory bindings: %w", err)

op-challenger/cmd/list_games.go

@@ -71,7 +71,10 @@ func ListGames(ctx *cli.Context) error {
 	defer l1Client.Close()
 
 	caller := batching.NewMultiCaller(l1Client.Client(), batching.DefaultBatchSize)
-	contract := contracts.NewDisputeGameFactoryContract(metrics.NoopContractMetrics, factoryAddr, caller)
+	contract, err := contracts.NewDisputeGameFactoryContract(ctx.Context, metrics.NoopContractMetrics, factoryAddr, caller)
+	if err != nil {
+		return fmt.Errorf("failed to create dispute game factory contract: %w", err)
+	}
 	head, err := l1Client.HeaderByNumber(ctx.Context, nil)
 	if err != nil {
 		return fmt.Errorf("failed to retrieve current head block: %w", err)