Address potential reentrancy vector on LivenessModule2 (#17975)

* Moved `delete challengeStartTime[_safe]` up

* I though pre-pr did this

* Version and semver-lock fix

* minor version bump

Author: alcueca

packages/contracts-bedrock/snapshots/semver-lock.json

@@ -208,8 +208,8 @@
     "sourceCodeHash": "0x7fc4789b082bc8ecd29c4c75a06058f0ff0b72f1c1028a42db6f1c35269c8865"
   },
   "src/safe/SaferSafes.sol:SaferSafes": {
-    "initCodeHash": "0xc546c21b73dce6c0b04ab5ddca56f61f648e26fc8345d0dcf160d94767dc4af6",
-    "sourceCodeHash": "0x22d773a7d6cc981b374b7cdc823e418293e0a82714757cac1ebb6079b2f9650b"
+    "initCodeHash": "0x54eb5d9d4dd6c7a6ac5c223c7e166cf30e93e11acb8caefab73eac596dba5af7",
+    "sourceCodeHash": "0xeb7745b3f5626573d1e935affbbb0e6b455e729f1d8b2da84ab0d5a46f848377"
   },
   "src/universal/OptimismMintableERC20.sol:OptimismMintableERC20": {
     "initCodeHash": "0x3c85eed0d017dca8eda6396aa842ddc12492587b061e8c756a8d32c4610a9658",

packages/contracts-bedrock/src/safe/LivenessModule2.sol

@@ -264,6 +264,9 @@ abstract contract LivenessModule2 {
             revert LivenessModule2_ResponsePeriodActive();
         }
 
+        // Reset the challenge state to allow a new challenge
+        delete challengeStartTime[_safe];
+
         // Get current owners
         address[] memory owners = _safe.getOwners();
 
@@ -296,9 +299,6 @@ abstract contract LivenessModule2 {
             revert LivenessModule2_OwnershipTransferFailed();
         }
 
-        // Reset the challenge state to allow a new challenge
-        delete challengeStartTime[_safe];
-
         // Disable the guard
         // Note that this will remove whichever guard is currently set on the Safe,
         // even if it is not the SaferSafes guard. This is intentional, as it is possible that the guard

packages/contracts-bedrock/src/safe/SaferSafes.sol

@@ -22,8 +22,8 @@ import { ISemver } from "interfaces/universal/ISemver.sol";
 ///      functionality is not desired, then there is no need to enable or configure it.
 contract SaferSafes is LivenessModule2, TimelockGuard, ISemver {
     /// @notice Semantic version.
-    /// @custom:semver 1.4.0
-    string public constant version = "1.4.0";
+    /// @custom:semver 1.5.0
+    string public constant version = "1.5.0";
 
     /// @notice Error for when the liveness response period is insufficient.
     error SaferSafes_InsufficientLivenessResponsePeriod();