Remove semver.yaml files, implementations.yaml and related code (#356)

* remove semver.yaml files, implementations.yaml and related code

* more tidy up

* remove accidental change

* remove superchain-wide versions check

* remove unused fns

* clean up rust bindings

Author: geoknee

CONTRIBUTING.md

@@ -7,7 +7,7 @@ The Superchain Registry repository contains:
   - a [`validation`](#validation-go-module) module
   - an [`add-chain`](#add-chain-go-module) module
   - The modules are tracked by a top level `go.work` file. The associated `go.work.sum` file is gitignored and not important to typical workflows, which should mirror those of the [CI configuration](.circleci/config.yml).
-* Automatically generated summary `chainIds.json` file
+* Automatically generated summary `chainList.json` and `chainList.toml` files.
 
 
 ## Superchain-wide config data
@@ -45,37 +45,8 @@ EOF
 ```
 Superchain-wide configuration, like the `ProtocolVersions` contract address, should be configured here when available.
 
-### Approved contract versions
-Each superchain target should have a `semver.yaml` file in the same directory declaring the approved contract semantic versions for that superchain, e.g:
-```yaml
-l1_cross_domain_messenger: 1.4.0
-l1_erc721_bridge: 1.0.0
-l1_standard_bridge: 1.1.0
-l2_output_oracle: 1.3.0
-optimism_mintable_erc20_factory: 1.1.0
-optimism_portal: 1.6.0
-system_config: 1.3.0
-
-# superchain-wide contracts
-protocol_versions: 1.0.0
-superchain_config: 1.1.0
-```
-It is meant to be used when building transactions that upgrade the implementations set in the proxies. See the `semver.yaml` files in existing superchain targets for the latest set of contracts to specify.
 
-### `implementations`
-Per superchain a set of canonical implementation deployments, per semver version, is tracked.
-As default, an empty collection of deployments can be set:
-```bash
-cat > superchain/implementations/networks/$SUPERCHAIN_TARGET.yaml << EOF
-l1_cross_domain_messenger:
-l1_erc721_bridge:
-l1_standard_bridge:
-l2_output_oracle:
-optimism_mintable_erc20_factory:
-optimism_portal:
-system_config:
-EOF
-```
+
 
 ## `superchain` Go Module
 

bindings/rust-bindings/src/embed.rs

@@ -5,6 +5,3 @@ pub(crate) static CONFIGS_DIR: Dir<'_> = include_dir!("$SUPERCHAIN_CONFIGS");
 
 /// Directory containing the extra files for the superchain.
 pub(crate) static EXTRA_DIR: Dir<'_> = include_dir!("$SUPERCHAIN_EXTRA");
-
-/// Directory containing the implementation addresses for the superchain.
-pub(crate) static IMPLEMENTATIONS_DIR: Dir<'_> = include_dir!("$SUPERCHAIN_IMPLEMENTATIONS");

bindings/rust-bindings/src/init.rs

@@ -4,27 +4,19 @@ use crate::embed;
 use alloc::{format, string::ToString, vec::Vec};
 use hashbrown::HashMap;
 use superchain_primitives::{
-    is_config_file, AddressList, Addresses, ChainConfig, ContractImplementations,
-    GenesisSystemConfigs, Implementations, OPChains, Superchain, SuperchainConfig, Superchains,
-    SystemConfig,
+    is_config_file, AddressList, Addresses, ChainConfig, GenesisSystemConfigs, OPChains,
+    Superchain, SuperchainConfig, Superchains, SystemConfig,
 };
 
 /// Tuple type holding the various initializers.
-pub(crate) type InitTuple = (
-    Superchains,
-    OPChains,
-    Addresses,
-    GenesisSystemConfigs,
-    Implementations,
-);
+pub(crate) type InitTuple = (Superchains, OPChains, Addresses, GenesisSystemConfigs);
 
 /// Initialize the superchain configurations from the embedded filesystem.
 pub(crate) fn load_embedded_configs() -> InitTuple {
     let mut superchains = HashMap::new();
     let mut op_chains = HashMap::new();
     let mut addresses = HashMap::new();
     let mut genesis_system_configs = HashMap::new();
-    let mut implementations = HashMap::new();
 
     for target_dir in embed::CONFIGS_DIR.dirs() {
         let target_name = target_dir.path().file_name().unwrap().to_str().unwrap();
@@ -90,9 +82,6 @@ pub(crate) fn load_embedded_configs() -> InitTuple {
             _ => {}
         }
 
-        let impls = new_contract_implementations(target_name);
-        implementations.insert(target_name.to_string(), impls);
-
         superchains.insert(
             target_name.to_string(),
             Superchain {
@@ -103,38 +92,5 @@ pub(crate) fn load_embedded_configs() -> InitTuple {
         );
     }
 
-    (
-        superchains,
-        op_chains,
-        addresses,
-        genesis_system_configs,
-        implementations,
-    )
-}
-
-fn new_contract_implementations(network: &str) -> ContractImplementations {
-    let implementations_data = embed::IMPLEMENTATIONS_DIR
-        .get_file("implementations.yaml")
-        .expect("Failed to find implementations.yaml file")
-        .contents();
-
-    let mut global_implementations: ContractImplementations =
-        serde_yaml::from_slice(implementations_data)
-            .expect("Failed to deserialize implementations.yaml file");
-
-    if network.is_empty() {
-        return global_implementations;
-    }
-
-    let network_implementations_data = embed::IMPLEMENTATIONS_DIR
-        .get_file(format!("networks/{}.yaml", network))
-        .expect("Failed to find network implementations.yaml file")
-        .contents();
-
-    let network_implementations = serde_yaml::from_slice(network_implementations_data)
-        .expect("Failed to deserialize network implementations.yaml file");
-
-    global_implementations.merge(network_implementations);
-
-    global_implementations
+    (superchains, op_chains, addresses, genesis_system_configs)
 }

bindings/rust-bindings/src/lib.rs

@@ -34,9 +34,6 @@ lazy_static::lazy_static! {
 
     /// Genesis system configurations exported from the registry
     pub static ref GENESIS_SYSTEM_CONFIGS: GenesisSystemConfigs = _INIT.3.clone();
-
-    /// Contract implementations exported from the registry
-    pub static ref IMPLEMENTATIONS: Implementations = _INIT.4.clone();
 }
 
 #[cfg(test)]

superchain/configs/mainnet/semver.yaml

@@ -6,7 +6,6 @@ require (
 	github.com/BurntSushi/toml v1.4.0
 	github.com/stretchr/testify v1.8.4
 	golang.org/x/crypto v0.18.0
-	golang.org/x/exp v0.0.0-20231110203233-9a3e6036ecaa
 	golang.org/x/mod v0.14.0
 	gopkg.in/yaml.v3 v3.0.1
 )

superchain/configs/sepolia-dev-0/semver.yaml

@@ -20,8 +20,6 @@ github.com/stretchr/testify v1.8.4 h1:CcVxjf3Q8PM0mHUKJCdn+eZZtm5yQwehR5yeSVQQcU
 github.com/stretchr/testify v1.8.4/go.mod h1:sz/lmYIOXD/1dqDmKjjqLyZ2RngseejIcXlSw2iwfAo=
 golang.org/x/crypto v0.18.0 h1:PGVlW0xEltQnzFZ55hkuX5+KLyrMYhHld1YHO4AKcdc=
 golang.org/x/crypto v0.18.0/go.mod h1:R0j02AL6hcrfOiy9T4ZYp/rcWeMxM3L6QYxlOuEG1mg=
-golang.org/x/exp v0.0.0-20231110203233-9a3e6036ecaa h1:FRnLl4eNAQl8hwxVVC17teOw8kdjVDVAiFMtgUdTSRQ=
-golang.org/x/exp v0.0.0-20231110203233-9a3e6036ecaa/go.mod h1:zk2irFbV9DP96SEBUUAy67IdHUaZuSnrz1n472HUCLE=
 golang.org/x/mod v0.14.0 h1:dGoOF9QVLYng8IHTm7BAyWqCqSheQ5pYWGhzW00YJr0=
 golang.org/x/mod v0.14.0/go.mod h1:hTbmBsO62+eylJbnUtE2MGJUyE7QWk4xUqPFrRgJ+7c=
 golang.org/x/sys v0.16.0 h1:xWw16ngr6ZMtmxDyKyIgsE93KNKz5HKmMa3b8ALHidU=