Bump devnet chains down to Frontier, prevent exclusions for Standard chains. (#385)

* relegate devnet chains to frontier, clear up exclusions

prevent any standard chain from having exclusions

* just codegen

* Tweak exclusion reason

* remove devnet standard config files

* remove reference to devnets

* move exclusion for op mainnet genesis hash check

Author: geoknee

chainList.json

@@ -208,25 +208,25 @@
     }
   },
   {
-    "name": "OP Labs Sepolia devnet 0",
-    "identifier": "sepolia-dev-0/oplabs-devnet-0",
-    "chainId": 11155421,
+    "name": "Base devnet 0",
+    "identifier": "sepolia-dev-0/base-devnet-0",
+    "chainId": 11763072,
     "rpc": [
       ""
     ],
     "explorers": [
       ""
     ],
-    "superchainLevel": 2,
+    "superchainLevel": 1,
     "parent": {
       "type": "L2",
       "chain": "sepolia-dev-0"
     }
   },
   {
-    "name": "Base devnet 0",
-    "identifier": "sepolia-dev-0/base-devnet-0",
-    "chainId": 11763072,
+    "name": "OP Labs Sepolia devnet 0",
+    "identifier": "sepolia-dev-0/oplabs-devnet-0",
+    "chainId": 11155421,
     "rpc": [
       ""
     ],

chainList.toml

@@ -142,20 +142,20 @@
     chain = "sepolia"
 
 [[chains]]
-  name = "OP Labs Sepolia devnet 0"
-  identifier = "sepolia-dev-0/oplabs-devnet-0"
-  chain_id = 11155421
+  name = "Base devnet 0"
+  identifier = "sepolia-dev-0/base-devnet-0"
+  chain_id = 11763072
   rpc = [""]
   explorers = [""]
-  superchain_level = 2
+  superchain_level = 1
   [chains.parent]
     type = "L2"
     chain = "sepolia-dev-0"
 
 [[chains]]
-  name = "Base devnet 0"
-  identifier = "sepolia-dev-0/base-devnet-0"
-  chain_id = 11763072
+  name = "OP Labs Sepolia devnet 0"
+  identifier = "sepolia-dev-0/oplabs-devnet-0"
+  chain_id = 11155421
   rpc = [""]
   explorers = [""]
   superchain_level = 1

superchain/configs/sepolia-dev-0/base-devnet-0.yaml

@@ -5,8 +5,6 @@ sequencer_rpc: ""
 explorer: ""
 
 superchain_level: 1
-standard_chain_candidate: true # This is a temporary field which causes most of the standard validation checks to run on this chain
-
 superchain_time: 1706634000 # joined from Ecotone
 
 system_config_addr: "0x7F67DC4959cb3E532B10A99F41bDD906C46FdFdE"

superchain/configs/sepolia-dev-0/oplabs-devnet-0.yaml

@@ -4,7 +4,7 @@ public_rpc: ""
 sequencer_rpc: ""
 explorer: ""
 
-superchain_level: 2
+superchain_level: 1
 superchain_time: 0 # Missing hardfork times are inherited from superchain.yaml
 
 system_config_addr: "0xa6b72407e2dc9EBF84b839B69A24C88929cf20F7"

validation/exclusions_test.go

@@ -3,6 +3,9 @@ package validation
 import (
 	"regexp"
 	"testing"
+
+	"github.com/ethereum-optimism/superchain-registry/superchain"
+	"github.com/stretchr/testify/require"
 )
 
 func skipIfExcluded(t *testing.T, chainID uint64) {
@@ -18,49 +21,51 @@ func skipIfExcluded(t *testing.T, chainID uint64) {
 }
 
 var exclusions = map[string]map[uint64]bool{
+	// Universal Checks
+	"Genesis_Hash_Check": {
+		// OP Mainnet has a pre-bedrock genesis (with an empty allocs object stored in the registry), so we exclude it from this check.")
+		10: true,
+	},
 	"ChainID_RPC_Check": {
 		11155421: true, // sepolia-dev-0/oplabs-devnet-0   No Public RPC declared
 		11763072: true, // sepolia-dev-0/base-devnet-0     No Public RPC declared
 	},
-	"GPO_Params": {
-		11155421: true, // sepolia-dev-0/oplabs-devnet-0   (no public endpoint)
-		11763072: true, // sepolia-dev-0/base-devnet-0     (no public endpoint)
-	},
-	"Superchain_Config": {
-		11763072: true, // sepolia-dev-0/base-devnet-0 (old version of OptimismPortal)
+	"Genesis_RPC_Check": {
+		11155421: true, // sepolia-dev-0/oplabs-devnet-0   No Public RPC declared
+		11763072: true, // sepolia-dev-0/base-devnet-0     No Public RPC declared
 	},
-	"L2OO_Params": {
-		11155421: true, // sepolia-dev-0/oplabs-devnet-0 (does not yet declare a contract versions tag)
-		11763072: true, // sepolia-dev-0/base-devnet-0  (does not yet declare a contract versions tag)
+	"Uniqueness_Check": {
+		11155421: true, // oplabs devnet 0, not in upstream repo
+		11763072: true, // base devnet 0, not in upstream repo}
 	},
+
+	// Standard Checks
 	"L1_Security_Config": {
 		8453:      true, // base (incorrect challenger, incorrect guardian)
-		11763072:  true, // base-devnet-0 (incorrect challenger, incorrect guardian)
-		90001:     true, // race (incorrect challenger, incorrect guardian)
 		84532:     true, // base-sepolia (incorrect challenger)
 		7777777:   true, // zora (incorrect challenger)
 		1750:      true, // metal (incorrect challenger)
 		919:       true, // mode sepolia (incorrect challenger)
 		999999999: true, // zora sepolia (incorrect challenger)
 		34443:     true, // mode (incorrect challenger)
 	},
-	"L2_Security_Config": {
-		11155421: true, // sepolia-dev-0/oplabs-devnet-0   No Public RPC declared
-		11763072: true, // sepolia-dev-0/base-devnet-0     No Public RPC declared
-	},
-	"Genesis_Hash_Check": {
-		10: true, // OP Mainnet
-	},
-	"Genesis_RPC_Check": {
-		11155421: true, // sepolia-dev-0/oplabs-devnet-0   No Public RPC declared
-		11763072: true, // sepolia-dev-0/base-devnet-0     No Public RPC declared
-	},
 	"Standard_Contract_Versions": {
 		11155421: true, // sepolia-dev-0/oplabs-devnet-0
 		11763072: true, // sepolia-dev-0/base-devnet-0
 	},
-	"Uniqueness_Check": {
-		11155421: true, // oplabs devnet 0, not in upstream repo
-		11763072: true, // base devnet 0, not in upstream repo}
-	},
+}
+
+func TestExclusions(t *testing.T) {
+	for name, v := range exclusions {
+		for k := range v {
+			if k == 10 && name == "Genesis_Hash_Check" {
+				// This is the sole standard chain validation check exclusion
+				continue
+			}
+			if v[k] {
+				require.NotNil(t, superchain.OPChains[k], k)
+				require.False(t, superchain.OPChains[k].SuperchainLevel == superchain.Standard, "Standard Chain %d may not be excluded from any check", k)
+			}
+		}
+	}
 }

validation/standard/init.go

@@ -19,7 +19,7 @@ func init() {
 
 	decodeTOMLFileIntoConfig("standard-config-roles-universal.toml", Config.Roles)
 
-	networks := []string{"mainnet", "sepolia", "sepolia-dev-0"}
+	networks := []string{"mainnet", "sepolia"}
 	for _, network := range networks {
 		Config.MultisigRoles[network] = new(MultisigRoles)
 		decodeTOMLFileIntoConfig("standard-config-roles-"+network+".toml", Config.MultisigRoles[network])

validation/standard/readme.md

@@ -1,7 +1,7 @@
 # Standard Rollup Blockspace Charter definition files
 This directory contains a number of TOML files which declare various parameters, addresses, contract versions and other data which define a **standard chain** in the sense of the [Standard Rollup Charter](https://gov.optimism.io/t/season-6-draft-standard-rollup-charter/8135).
 
-Distinct, named declaration files have been added (where necessary) to allow testnets and devnets to have greater flexibility in their configurations.
+Distinct, named declaration files have been added (where necessary) to allow testnets to have greater flexibility in their configurations.
 
 Parameters may be declared to be equal to a pair of values, meaning that the parameter must be within the bounds defined by those values.
 

validation/standard/standard-config-params-sepolia-dev-0.toml

@@ -16,6 +16,7 @@ import (
 
 func testGenesisHash(t *testing.T, chainID uint64) {
 	skipIfExcluded(t, chainID)
+
 	chainConfig, ok := OPChains[chainID]
 	if !ok {
 		t.Fatalf("no chain with ID %d found", chainID)
@@ -27,8 +28,6 @@ func testGenesisHash(t *testing.T, chainID uint64) {
 	// superchain.OPChains, superchain.LoadGenesis, superchain.LoadContractBytecode
 	// to reconstruct a core.Genesis and compute its block hash.
 	// We can then compare that against the declared genesis block hash.
-	// TODO core.LoadOPStackGenesis actually already performs the check we are about to do
-	// TODO core.LoadOPStackGenesis could be moved to superchain
 	computedGenesis, err := core.LoadOPStackGenesis(chainID)
 	require.NoError(t, err)