Skip to content

Commit 4c60dad

Browse files
authored
Merge branch 'fix-7251-tests' into pr/ralexstokes/3656-1
2 parents bb597fc + b87f1fc commit 4c60dad

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

62 files changed

+478
-1128
lines changed

.circleci/config.yml

Lines changed: 4 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ jobs:
155155
command: make citest fork=deneb
156156
- store_test_results:
157157
path: tests/core/pyspec/test-reports
158-
test-eip6110:
158+
test-electra:
159159
docker:
160160
- image: circleci/python:3.9
161161
working_directory: ~/specs-repo
@@ -165,20 +165,7 @@ jobs:
165165
- restore_pyspec_cached_venv
166166
- run:
167167
name: Run py-tests
168-
command: make citest fork=eip6110
169-
- store_test_results:
170-
path: tests/core/pyspec/test-reports
171-
test-eip7002:
172-
docker:
173-
- image: circleci/python:3.9
174-
working_directory: ~/specs-repo
175-
steps:
176-
- restore_cache:
177-
key: v3-specs-repo-{{ .Branch }}-{{ .Revision }}
178-
- restore_pyspec_cached_venv
179-
- run:
180-
name: Run py-tests
181-
command: make citest fork=eip7002
168+
command: make citest fork=electra
182169
- store_test_results:
183170
path: tests/core/pyspec/test-reports
184171
test-eip7251:
@@ -194,19 +181,6 @@ jobs:
194181
command: make citest fork=eip7251
195182
- store_test_results:
196183
path: tests/core/pyspec/test-reports
197-
test-eip7549:
198-
docker:
199-
- image: circleci/python:3.9
200-
working_directory: ~/specs-repo
201-
steps:
202-
- restore_cache:
203-
key: v3-specs-repo-{{ .Branch }}-{{ .Revision }}
204-
- restore_pyspec_cached_venv
205-
- run:
206-
name: Run py-tests
207-
command: make citest fork=eip7549
208-
- store_test_results:
209-
path: tests/core/pyspec/test-reports
210184
test-whisk:
211185
docker:
212186
- image: circleci/python:3.9
@@ -353,18 +327,12 @@ workflows:
353327
- test-deneb:
354328
requires:
355329
- install_pyspec_test
356-
- test-eip6110:
357-
requires:
358-
- install_pyspec_test
359-
- test-eip7002:
330+
- test-electra:
360331
requires:
361332
- install_pyspec_test
362333
- test-eip7251:
363334
requires:
364335
- install_pyspec_test
365-
- test-eip7549:
366-
requires:
367-
- install_pyspec_test
368336
- test-whisk:
369337
requires:
370338
- install_pyspec_test
@@ -376,7 +344,7 @@ workflows:
376344
- lint:
377345
requires:
378346
- install_pyspec_test
379-
# NOTE: Since phase 0 has been launched, we disabled the deposit contract tests.
347+
# NOTE: Since phase 0 has been launched, we disabled the deposit contract tests.
380348
# - install_deposit_contract_web3_tester:
381349
# requires:
382350
# - checkout_specs

.github/workflows/run-tests.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@ env:
1010
on:
1111
push:
1212
branches:
13-
- dev
13+
- dev
1414
- master
15-
pull_request:
15+
pull_request:
1616
workflow_dispatch:
1717
inputs:
1818
test_preset_type:
@@ -71,22 +71,22 @@ jobs:
7171
needs: [preclear,lint,codespell,table_of_contents]
7272
strategy:
7373
matrix:
74-
version: ["phase0", "altair", "bellatrix", "capella", "deneb", "eip6110", "eip7002", "eip7251", "eip7549", "whisk", "eip7594"]
74+
version: ["phase0", "altair", "bellatrix", "capella", "deneb", "electra", "eip7251", "whisk", "eip7594"]
7575
steps:
7676
- name: Checkout this repo
7777
uses: actions/[email protected]
7878
- name: set TEST_PRESET_TYPE
79-
if: github.event.inputs.test_preset_type != ''
79+
if: github.event.inputs.test_preset_type != ''
8080
run: |
8181
echo "spec_test_preset_type=${{ github.event.inputs.test_preset_type || env.TEST_PRESET_TYPE }}" >> $GITHUB_ENV
8282
- name: set TEST_PRESET_TYPE
8383
if: ${{ (github.event_name == 'push' && github.ref_name != 'master') || github.event_name == 'pull_request' }}
8484
run: |
85-
echo "spec_test_preset_type=${{ env.TEST_PRESET_TYPE}}" >> $GITHUB_ENV
85+
echo "spec_test_preset_type=${{ env.TEST_PRESET_TYPE}}" >> $GITHUB_ENV
8686
- name: set TEST_PRESET_TYPE
8787
if: ${{ github.event_name == 'push' && github.ref_name == 'master' }}
8888
run: |
89-
echo "spec_test_preset_type=mainnet" >> $GITHUB_ENV
89+
echo "spec_test_preset_type=mainnet" >> $GITHUB_ENV
9090
- name: set TEST_PRESET_TYPE
9191
if: github.event.schedule=='0 0 * * *'
9292
run: |

.gitignore

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,7 @@ tests/core/pyspec/eth2spec/altair/
2121
tests/core/pyspec/eth2spec/bellatrix/
2222
tests/core/pyspec/eth2spec/capella/
2323
tests/core/pyspec/eth2spec/deneb/
24-
tests/core/pyspec/eth2spec/eip6110/
25-
tests/core/pyspec/eth2spec/eip7002/
26-
tests/core/pyspec/eth2spec/eip7549/
24+
tests/core/pyspec/eth2spec/electra/
2725
tests/core/pyspec/eth2spec/whisk/
2826
tests/core/pyspec/eth2spec/eip7251/
2927
tests/core/pyspec/eth2spec/eip7594/

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ MARKDOWN_FILES = $(wildcard $(SPEC_DIR)/*/*.md) \
3535
$(wildcard $(SPEC_DIR)/_features/*/*/*.md) \
3636
$(wildcard $(SSZ_DIR)/*.md)
3737

38-
ALL_EXECUTABLE_SPEC_NAMES = phase0 altair bellatrix capella deneb eip6110 eip7002 eip7251 eip7549 whisk
38+
ALL_EXECUTABLE_SPEC_NAMES = phase0 altair bellatrix capella deneb electra eip7251 whisk
3939
# The parameters for commands. Use `foreach` to avoid listing specs again.
4040
COVERAGE_SCOPE := $(foreach S,$(ALL_EXECUTABLE_SPEC_NAMES), --cov=eth2spec.$S.$(TEST_PRESET_TYPE))
4141
PYLINT_SCOPE := $(foreach S,$(ALL_EXECUTABLE_SPEC_NAMES), ./eth2spec/$S)
@@ -244,5 +244,5 @@ build_docs: copy_docs
244244
mkdocs build
245245

246246
serve_docs:
247-
. venv/bin/activate;
247+
. venv/bin/activate;
248248
mkdocs serve

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,10 @@ Features are researched and developed in parallel, and then consolidated into se
2626
### In-development Specifications
2727
| Code Name or Topic | Specs | Notes |
2828
| - | - | - |
29+
| Electra | <ul><li>Core</li><ul><li>[Beacon Chain changes](specs/electra/beacon-chain.md)</li><li>[EIP-6110 fork](specs/electra/fork.md)</li></ul><li>Additions</li><ul><li>[Honest validator guide changes](specs/electra/validator.md)</li></ul></ul> |
2930
| Sharding (outdated) | <ul><li>Core</li><ul><li>[Beacon Chain changes](specs/_features/sharding/beacon-chain.md)</li></ul><li>Additions</li><ul><li>[P2P networking](specs/_features/sharding/p2p-interface.md)</li></ul></ul> |
3031
| Custody Game (outdated) | <ul><li>Core</li><ul><li>[Beacon Chain changes](specs/_features/custody_game/beacon-chain.md)</li></ul><li>Additions</li><ul><li>[Honest validator guide changes](specs/_features/custody_game/validator.md)</li></ul></ul> | Dependent on sharding |
3132
| Data Availability Sampling (outdated) | <ul><li>Core</li><ul><li>[Core types and functions](specs/_features/das/das-core.md)</li><li>[Fork choice changes](specs/_features/das/fork-choice.md)</li></ul><li>Additions</li><ul><li>[P2P Networking](specs/_features/das/p2p-interface.md)</li><li>[Sampling process](specs/_features/das/sampling.md)</li></ul></ul> | <ul><li> Dependent on sharding</li><li>[Technical explainer](https://hackmd.io/@HWeNw8hNRimMm2m2GH56Cw/B1YJPGkpD)</li></ul> |
32-
| EIP-6110 | <ul><li>Core</li><ul><li>[Beacon Chain changes](specs/_features/eip6110//beacon-chain.md)</li><li>[EIP-6110 fork](specs/_features/eip6110/fork.md)</li></ul><li>Additions</li><ul><li>[Honest validator guide changes](specs/_features/eip6110/validator.md)</li></ul></ul> |
3333

3434
### Accompanying documents can be found in [specs](specs) and include:
3535

configs/mainnet.yaml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -53,18 +53,9 @@ DENEB_FORK_EPOCH: 269568 # March 13, 2024, 01:55:35pm UTC
5353
# Electra
5454
ELECTRA_FORK_VERSION: 0x05000000
5555
ELECTRA_FORK_EPOCH: 18446744073709551615
56-
# EIP6110
57-
EIP6110_FORK_VERSION: 0x06000000 # temporary stub
58-
EIP6110_FORK_EPOCH: 18446744073709551615
59-
# EIP7002
60-
EIP7002_FORK_VERSION: 0x07000000 # temporary stub
61-
EIP7002_FORK_EPOCH: 18446744073709551615
6256
# EIP7251
6357
EIP7251_FORK_VERSION: 0x06000000 # temporary stub
6458
EIP7251_FORK_EPOCH: 18446744073709551615
65-
# EIP7549
66-
EIP7549_FORK_VERSION: 0x06000000 # temporary stub
67-
EIP7549_FORK_EPOCH: 18446744073709551615
6859
# WHISK
6960
WHISK_FORK_VERSION: 0x08000000 # temporary stub
7061
WHISK_FORK_EPOCH: 18446744073709551615

configs/minimal.yaml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -52,18 +52,9 @@ DENEB_FORK_EPOCH: 18446744073709551615
5252
# Electra
5353
ELECTRA_FORK_VERSION: 0x05000001
5454
ELECTRA_FORK_EPOCH: 18446744073709551615
55-
# EIP6110
56-
EIP6110_FORK_VERSION: 0x06000001
57-
EIP6110_FORK_EPOCH: 18446744073709551615
58-
# EIP7002
59-
EIP7002_FORK_VERSION: 0x07000001
60-
EIP7002_FORK_EPOCH: 18446744073709551615
6155
# EIP7251
6256
EIP7251_FORK_VERSION: 0x06000001 # temporary stub
6357
EIP7251_FORK_EPOCH: 18446744073709551615
64-
# EIP7549
65-
EIP7549_FORK_VERSION: 0x06000001 # temporary stub
66-
EIP7549_FORK_EPOCH: 18446744073709551615
6758
# WHISK
6859
WHISK_FORK_VERSION: 0x08000001
6960
WHISK_FORK_EPOCH: 18446744073709551615

presets/mainnet/eip6110.yaml

Lines changed: 0 additions & 6 deletions
This file was deleted.

presets/mainnet/eip7549.yaml

Lines changed: 0 additions & 8 deletions
This file was deleted.

presets/mainnet/electra.yaml

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
# Mainnet preset - Electra
2+
3+
# # Max operations per block
4+
# ---------------------------------------------------------------
5+
# `uint64(2**0)` (= 1)
6+
MAX_ATTESTER_SLASHINGS_ELECTRA: 1
7+
# `uint64(2 * 3)` (= 8)
8+
MAX_ATTESTATIONS_ELECTRA: 8
9+
10+
# Execution
11+
# ---------------------------------------------------------------
12+
# 2**13 (= 8192) receipts
13+
MAX_DEPOSIT_RECEIPTS_PER_PAYLOAD: 8192
14+
# 2**4 (= 16) exits
15+
MAX_EXECUTION_LAYER_EXITS: 16

0 commit comments

Comments
 (0)