Skip to content

Commit 4cf2e30

Browse files
authored
Revert "Deduplicate test cases in generator" (#4716)
This PR reverts the following: * #4706 (1) This didn't actually fix the issue and more importantly (2) it results in missing test cases. This is apparent if you look at the size of the zip files in the beta.2 release. Thank you @etan-status for pointing this out.
1 parent 92dda6f commit 4cf2e30

File tree

1 file changed

+1
-15
lines changed

1 file changed

+1
-15
lines changed

tests/core/pyspec/eth2spec/gen_helpers/gen_base/gen_runner.py

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -130,23 +130,9 @@ def debug_print(msg):
130130
# Gracefully handle Ctrl+C
131131
install_sigint_handler(console)
132132

133-
# Deduplicate test cases based on identifier
134-
input_test_cases_list = list(input_test_cases)
135-
seen_identifiers = {}
136-
deduplicated_test_cases = []
137-
for test_case in input_test_cases_list:
138-
identifier = test_case.get_identifier()
139-
if identifier not in seen_identifiers:
140-
seen_identifiers[identifier] = True
141-
deduplicated_test_cases.append(test_case)
142-
143-
debug_print(f"Total test cases before deduplication: {len(input_test_cases_list)}")
144-
debug_print(f"Total test cases after deduplication: {len(deduplicated_test_cases)}")
145-
debug_print(f"Duplicates removed: {len(input_test_cases_list) - len(deduplicated_test_cases)}")
146-
147133
total_found = 0
148134
selected_test_cases = []
149-
for test_case in deduplicated_test_cases:
135+
for test_case in input_test_cases:
150136
total_found += 1
151137
# Check if the test case should be filtered out
152138
if len(args.runners) != 0 and test_case.runner_name not in args.runners:

0 commit comments

Comments
 (0)