Skip to content

Commit 8f044ab

Browse files
authored
EIP-7594: Specify inclusion proof function to run.
For by root and by range requests checks, the exact function to run is specified for KZG commitments, but not for the inclusion proof. This PR aligns both checks.
1 parent c1a3b86 commit 8f044ab

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

specs/_features/eip7594/p2p-interface.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,7 @@ Requests sidecars by block root and index.
223223
The response is a list of `DataColumnIdentifier` whose length is less than or equal to the number of requests.
224224
It may be less in the case that the responding peer is missing blocks or sidecars.
225225

226-
Before consuming the next response chunk, the response reader SHOULD verify the data column sidecar is well-formatted, has valid inclusion proof, and is correct w.r.t. the expected KZG commitments through `verify_data_column_sidecar_kzg_proofs`.
226+
Before consuming the next response chunk, the response reader SHOULD verify the data column sidecar is well-formatted, has valid inclusion proof through `verify_data_column_sidecar_inclusion_proof`, and is correct w.r.t. the expected KZG commitments through `verify_data_column_sidecar_kzg_proofs`.
227227

228228
No more than `MAX_REQUEST_DATA_COLUMN_SIDECARS` may be requested at a time.
229229

@@ -269,7 +269,7 @@ Response Content:
269269

270270
Requests data column sidecars in the slot range `[start_slot, start_slot + count)` of the given `columns`, leading up to the current head block as selected by fork choice.
271271

272-
Before consuming the next response chunk, the response reader SHOULD verify the data column sidecar is well-formatted, has valid inclusion proof, and is correct w.r.t. the expected KZG commitments through `verify_data_column_sidecar_kzg_proofs`.
272+
Before consuming the next response chunk, the response reader SHOULD verify the data column sidecar is well-formatted, has valid inclusion proof through `verify_data_column_sidecar_inclusion_proof`, and is correct w.r.t. the expected KZG commitments through `verify_data_column_sidecar_kzg_proofs`.
273273

274274
`DataColumnSidecarsByRange` is primarily used to sync data columns that may have been missed on gossip and to sync within the `MIN_EPOCHS_FOR_DATA_COLUMN_SIDECARS_REQUESTS` window.
275275

0 commit comments

Comments
 (0)