Merge pull request #3885 from etan-status/bf-emptytxspec

Synchronously check all `transactions` to have non-zero length

Author: jtraglia

specs/bellatrix/beacon-chain.md

@@ -355,10 +355,17 @@ def verify_and_notify_new_payload(self: ExecutionEngine,
     """
     Return ``True`` if and only if ``new_payload_request`` is valid with respect to ``self.execution_state``.
     """
-    if not self.is_valid_block_hash(new_payload_request.execution_payload):
+    execution_payload = new_payload_request.execution_payload
+
+    if b'' in execution_payload.transactions:
         return False
-    if not self.notify_new_payload(new_payload_request.execution_payload):
+
+    if not self.is_valid_block_hash(execution_payload):
         return False
+
+    if not self.notify_new_payload(execution_payload):
+        return False
+
     return True
 ```
 

specs/deneb/beacon-chain.md

@@ -294,7 +294,10 @@ def verify_and_notify_new_payload(self: ExecutionEngine,
     Return ``True`` if and only if ``new_payload_request`` is valid with respect to ``self.execution_state``.
     """
     execution_payload = new_payload_request.execution_payload
-    parent_beacon_block_root = new_payload_request.parent_beacon_block_root
+    parent_beacon_block_root = new_payload_request.parent_beacon_block_root  # [New in Deneb:EIP4788]
+
+    if b'' in execution_payload.transactions:
+        return False
 
     # [Modified in Deneb:EIP4788]
     if not self.is_valid_block_hash(execution_payload, parent_beacon_block_root):

specs/electra/beacon-chain.md

@@ -1030,6 +1030,9 @@ def verify_and_notify_new_payload(self: ExecutionEngine,
     parent_beacon_block_root = new_payload_request.parent_beacon_block_root
     execution_requests_list = get_execution_requests_list(new_payload_request.execution_requests)  # [New in Electra]
 
+    if b'' in execution_payload.transactions:
+        return False
+
     if not self.is_valid_block_hash(execution_payload, parent_beacon_block_root):
         return False