Skip to content

Commit fe5b388

Browse files
authored
Clean up old references to make pyspec (#4549)
As of #4548 the `make pyspec` command is no more. This PR cleans up some references to it that I missed.
1 parent 3080ccb commit fe5b388

File tree

3 files changed

+11
-27
lines changed

3 files changed

+11
-27
lines changed

.github/workflows/docs.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ jobs:
2323
cache: 'pip'
2424

2525
- name: Install dependencies to venv
26-
run: make pyspec
26+
run: make _pyspec
2727

2828
- name: Build docs
2929
run: make _copy_docs

tests/README.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -382,8 +382,7 @@ processes the attestation and returns the result.
382382
383383
Attestations can't happen in the same block as the one about which they are
384384
attesting, or in a block that is after the block is finalized. This is specified
385-
as part of the specs, in the `process_attestation` function (which is created
386-
from the spec by the `make pyspec` command you ran earlier). Here is the
385+
as part of the specs, in the `process_attestation` function. Here is the
387386
relevant code fragment:
388387
389388
```python

tests/generators/compliance_runners/fork_choice/README.md

Lines changed: 9 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -15,49 +15,34 @@ with a minor exception (new check added).
1515

1616
This work was supported by a grant from the Ethereum Foundation.
1717

18-
# Pre-requisites
19-
20-
Install pyspec using the top-level Makefile, this will install necessary
21-
pre-requiesites.
22-
23-
```
24-
> make pyspec
25-
```
26-
2718
# Generating tests
2819

2920
From the root directory:
3021

3122
```
32-
> python -m tests.generators.compliance_runners.fork_choice.test_gen -o ${test_dir} --fc-gen-config ${config}
33-
```
34-
35-
where `config` can be either: `tiny`, `small` or \`standard.
36-
37-
Or specify path to the configuration file directly:
38-
39-
```
40-
> python -m tests.generators.compliance_runners.fork_choice.test_gen -o ${test_dir} --fc-gen-config-path ${config_path}
23+
make comptests fc_gen_config=<config>
4124
```
4225

43-
There are three configurations in the repo: [tiny](tiny/), [small](small/) and
44-
[standard](standard/).
26+
where `config` can be either: [`tiny`](tiny/), [`small`](small/) or
27+
[`standard`](standard/).
4528

4629
# Running tests
4730

4831
From the root directory:
4932

5033
```
51-
> python -m tests.generators.compliance_runners.fork_choice.test_run -i ${test_dir}
34+
make _pyspec # Initialize virtual environment
35+
python -m tests.generators.compliance_runners.fork_choice.test_run -i ${test_dir}
5236
```
5337

5438
# Generating configurations
5539

56-
Files in [tiny](tiny/), [small](small/) and [standard](standard/) are generated
57-
with [generate_test_instances.py](generate_test_instances.py), e.g.
40+
Files in [`tiny`](tiny/), [`small`](small/) and [`standard`](standard/) are
41+
generated with [`generate_test_instances.py`](generate_test_instances.py), e.g.
5842

5943
```
60-
> python -m tests.generators.compliance_runners.fork_choice.generate_test_instances
44+
make _pyspec # Initialize virtual environment
45+
python -m tests.generators.compliance_runners.fork_choice.generate_test_instances
6146
```
6247

6348
But one normally doesn't need to generate them.

0 commit comments

Comments
 (0)