Skip to content

Commit 563e3dd

Browse files
author
Emilia Hane
committed
fixup! Grammar fix
1 parent cb050ca commit 563e3dd

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

discv5/discv5-theory.md

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -441,21 +441,24 @@ frequently have to re-establish sessions to its peers.
441441
442442
### Limiting resource consumption of peers behind symmetric NATs, useful for light-clients
443443
444-
Peers with uncontactable ENRs do not get inserted into kbuckets. Nodes that are behind
444+
Peers with unreachable ENRs do not get inserted into kbuckets. Nodes that are behind
445445
symmetric NATs will naturally never succeed in pinpointing one external socket for peers
446-
to reach them on by [runtime address discovery] and therefore their uncontactable ENRs
447-
will never update to contactable ENRs. This means, these peers will never respond to
446+
to reach them on by [runtime address discovery] and therefore their unreachable ENRs
447+
will never update to reachable ENRs. This means, these peers will never respond to
448448
requests, as only peers in kbucktes are sent requests. This does not cohere with the
449-
p2p-model, rather the server-client model where the peer with a uncontactable ENR acts
449+
p2p-model, rather the server-client model where the peer with a unreachable ENR acts
450450
as the client. This misalignment is especially bothersome for well behaving (externally
451451
reachable) light-clients operating on limited resources. Discv5.2 corrects this
452452
side-effect of [runtime address discovery] by setting introducing a configurable limit to
453-
the number of sessions at a time with peers with uncontactable ENRs, the lower limit
454-
being 1. Nodes must accept sessions with at least one peer with a uncontactable ENR to
453+
the number of sessions at a time with peers with unreachable ENRs, the lower limit
454+
being 1. Nodes must accept sessions with at least one peer with a unreachable ENR to
455455
for [runtime address discovery] to be enabled on the discv5.2 network.
456456
457457
### Fault tolerance
458458
459+
As was already the case in discv5, if a request to a node times out, (after the configured
460+
number of retries) that peer is considered unresponsive and the session can be failed.
461+
459462
[EIP-778]: ../enr.md
460463
[identity scheme]: ../enr.md#record-structure
461464
[message packet]: ./discv5-wire.md#ordinary-message-packet-flag--0

0 commit comments

Comments
 (0)