Add some ERC-related naming edge cases (#342)

* Add some ERC-related naming edge cases

Signed-off-by: Gavin John <[email protected]>

* Add test case

Signed-off-by: Gavin John <[email protected]>

---------

Signed-off-by: Gavin John <[email protected]>

Author: Pandapip1

src/__tests__/namePR.test.ts

@@ -241,4 +241,20 @@ describe("namePR", () => {
         } as PullRequest, files);
         expect(prTitle).toEqual(`${localConfig.title.updateEipPrefix.replace("EIP", "ERC").replace("XXXX", "9999")}PR Title Testing 123 (Update ERC-9999)`);
     });
+    
+    it("Correctly Names Simulated PR-18: Modifies ERC-1", async () => {
+        let files = [{
+            filename: "ERCS/erc-1.md",
+            status: "modified",
+            contents: "---\ntitle: EIP Rules And Guidelines\nstatus: Living\n---\n## Testing1",
+            previous_contents: "---\ntitle: EIP Rules And Guidelines\nstatus: Living\n---\n## Testing2"
+        }] as File[];
+        const prTitle = await generatePRTitle({
+            title: "PR Title Testing 123 (ERC-1)",
+            user: {
+                login: "testUser"
+            } as User
+        } as PullRequest, files);
+        expect(prTitle).toEqual(`${localConfig.title.updateEipPrefix.replace("EIP", "ERC").replace("XXXX", "1")}PR Title Testing 123 (ERC-1)`);
+    });
 });

src/namePr.ts

@@ -21,7 +21,7 @@ export async function generatePRTitle(pull_request: PullRequest, files: File[])
 
     // If the PR modifies the website, use Website prefix unless the beginning portion is for EIP-1
     if (
-        (files.some(file => file.filename.endsWith(".html") || file.filename.endsWith(".js") || file.filename.endsWith(".css") || (file.filename.startsWith("assets/") && !file.filename.startsWith("assets/eip-")))) &&
+        (files.some(file => file.filename.endsWith(".html") || file.filename.endsWith(".js") || file.filename.endsWith(".css") || (file.filename.startsWith("assets/") && !file.filename.startsWith("assets/eip-") && !file.filename.startsWith("assets/erc-")))) &&
         (!beginnningPortion || !beginnningPortion.toLowerCase().endsWith("eip-1"))
     ) {
         return localConfig.title.websitePrefix + title;
@@ -32,6 +32,11 @@ export async function generatePRTitle(pull_request: PullRequest, files: File[])
         return localConfig.title.updateEipPrefix.replace("EIP-XXXX", "EIP-1") + title;
     }
 
+    // If the PR modifies ERC-1, indicate that
+    if (files.some(file => file.filename == "ERCS/erc-1.md")) {
+        return localConfig.title.updateEipPrefix.replace("EIP-XXXX", "ERC-1") + title;
+    }
+    
     // If the PR changes a file in the .github/workflows directory, use CI prefix
     if (files.some(file => file.filename.startsWith(".github/workflows"))) {
         return localConfig.title.ciPrefix + title;