fix links for static internal files

Author: pettinarip

src/components/AssetDownload/index.tsx

@@ -56,22 +56,12 @@ const AssetDownload = ({
         )}
       </div>
       <Flex className="mt-4 gap-5">
-        <ButtonLink
-          href={imgSrc}
-          onClick={matomoHandler}
-          target="_blank"
-          locale={false}
-        >
+        <ButtonLink href={imgSrc} onClick={matomoHandler} target="_blank">
           {t("page-assets-download-download")} (
           {extname(imgSrc).slice(1).toUpperCase()})
         </ButtonLink>
         {svgUrl && (
-          <ButtonLink
-            href={svgUrl}
-            onClick={matomoHandler}
-            target="_blank"
-            locale={false}
-          >
+          <ButtonLink href={svgUrl} onClick={matomoHandler} target="_blank">
             {t("page-assets-download-download")} (SVG)
           </ButtonLink>
         )}

src/components/MarkdownImage.tsx

@@ -1,13 +1,13 @@
 import { extname } from "path"
 
+import NextLink from "next/link"
+
 import { Image, type ImageProps } from "@/components/Image"
 
 import { toPosixPath } from "@/lib/utils/relativePath"
 
 import { CONTENT_IMAGES_MAX_WIDTH } from "@/lib/constants"
 
-import InlineLink from "./ui/Link"
-
 interface MarkdownImageProps extends Omit<ImageProps, "width" | "height"> {
   width: string
   height: string
@@ -42,12 +42,7 @@ const MarkdownImage = ({
     // display the wrapper as a `span` to avoid dom nesting warnings as mdx
     // sometimes wraps images in `p` tags
     <span className="flex justify-center">
-      <InlineLink
-        href={transformedSrc}
-        target="_blank"
-        rel="noopener"
-        locale={false}
-      >
+      <NextLink href={transformedSrc} target="_blank" rel="noopener">
         <Image
           alt={alt}
           width={imageWidth}
@@ -58,7 +53,7 @@ const MarkdownImage = ({
           className="h-auto"
           {...rest}
         />
-      </InlineLink>
+      </NextLink>
     </span>
   )
 }

src/components/ui/Link.tsx

@@ -1,4 +1,4 @@
-import { AnchorHTMLAttributes, forwardRef } from "react"
+import { AnchorHTMLAttributes, ComponentProps, forwardRef } from "react"
 import NextLink from "next/link"
 import { RxExternalLink } from "react-icons/rx"
 import { VisuallyHidden } from "@radix-ui/react-visually-hidden"
@@ -23,7 +23,7 @@ type BaseProps = {
 
 export type LinkProps = BaseProps &
   AnchorHTMLAttributes<HTMLAnchorElement> &
-  Omit<typeof I18nLink, "href">
+  Omit<ComponentProps<typeof I18nLink>, "href">
 
 /**
  * Link wrapper which handles:
@@ -60,14 +60,14 @@ export const BaseLink = forwardRef<HTMLAnchorElement, LinkProps>(function Link(
 
   const isActive = url.isHrefActive(href, pathname, isPartiallyActive)
   const isDiscordInvite = url.isDiscordInvite(href)
-  const isPdf = url.isPdf(href)
+  const isFile = url.isFile(href)
   const isExternal = url.isExternal(href)
-  const isInternalPdf = isPdf && !isExternal
+  const isInternalFile = isFile && !isExternal
   const isHash = url.isHash(href)
 
-  // Get proper download link for internally hosted PDF's & static files (ex: whitepaper)
+  // Get proper download link for internally hosted files (ex: whitepaper.pdf)
   // Opens in separate window.
-  if (isInternalPdf) {
+  if (isInternalFile && !href.startsWith("/")) {
     href = "/" + getRelativePath(pathname, href)
   }
 
@@ -113,7 +113,7 @@ export const BaseLink = forwardRef<HTMLAnchorElement, LinkProps>(function Link(
     )
   }
 
-  if (isInternalPdf) {
+  if (isInternalFile) {
     return (
       <NextLink
         target="_blank"

src/lib/utils/url.ts

@@ -1,4 +1,4 @@
-import { join } from "path"
+import { extname, join } from "path"
 
 import {
   DEFAULT_LOCALE,
@@ -21,6 +21,8 @@ export const isGlossary = (href: string): boolean =>
 
 export const isPdf = (href: string): boolean => href.endsWith(".pdf")
 
+export const isFile = (href: string): boolean => extname(href).length > 0
+
 export const sanitizeHitUrl = (url: string): string =>
   url
     .replace(/^https?:\/\/[^/]+(?=\/)/, "")

src/pages/[locale]/assets.tsx

@@ -132,8 +132,7 @@ export const getStaticProps = (async ({ params }) => {
 const AssetsPage = () => {
   // Ignore locale in the URL for SVG path in public directory to fix broken link
   // SVG path changes from /en/images => /images
-  const svgPathFromOrigin =
-    typeof window !== `undefined` ? window.location.origin : ""
+  const svgPathFromOrigin = ""
 
   const { t } = useTranslation("page-assets")
   const assetPageHeroImage = useColorModeValue(