chore: apply suggestions from code review

Co-Authored-By: Pablo Pettinari <[email protected]>

Author: wackerow

src/scripts/crowdin/import/utils.ts

@@ -2,6 +2,7 @@ import { copyFileSync, existsSync, mkdirSync, readdirSync } from "fs"
 import { join } from "path"
 
 import i18Config from "../../../../i18n.config.json"
+import { INTL_JSON_DIR, TRANSLATIONS_DIR } from "../../../lib/constants"
 import { DOT_CROWDIN } from "../translations/constants"
 
 import { BucketsList, SelectionItem, SummaryItem, TrackerObject } from "./types"
@@ -18,26 +19,26 @@ export const getCrowdinCode = (code: string): string =>
  * to their corresponding destinations in the repo. Function is called
  * again recursively for subdirectories.
  *
- * @param _path An absolute path to the directory being scraped.
+ * @param path An absolute path to the directory being scraped.
  * @param contentSubpath The subpath deep to the lang-code directory,
  * used to construct destination for markdown content files
  * @param repoLangCode Language code used within the repo
  * @returns void
  */
 export const scrapeDirectory = (
-  _path: string,
+  path: string,
   contentSubpath: string,
   repoLangCode: string,
   trackers: TrackerObject
 ): void => {
-  if (!existsSync(_path)) return
-  const ls: string[] = readdirSync(_path).filter(
+  if (!existsSync(path)) return
+  const ls: string[] = readdirSync(path).filter(
     (dir: string) => !dir.startsWith(".")
   )
   ls.forEach((item: string) => {
-    const source: string = join(_path, item)
+    const source: string = join(path, item)
     if (item.endsWith(".json")) {
-      const jsonDestDirPath: string = join("src", "intl", repoLangCode)
+      const jsonDestDirPath: string = join(INTL_JSON_DIR, repoLangCode)
       if (!existsSync(jsonDestDirPath))
         mkdirSync(jsonDestDirPath, { recursive: true })
       const jsonDestinationPath: string = join(jsonDestDirPath, item)
@@ -50,9 +51,7 @@ export const scrapeDirectory = (
       item.endsWith(".xlsx")
     ) {
       const mdDestDirPath: string = join(
-        "public",
-        "content",
-        "translations",
+        TRANSLATIONS_DIR,
         repoLangCode,
         contentSubpath
       )
@@ -65,7 +64,7 @@ export const scrapeDirectory = (
     } else {
       // If another directory, recursively call `scrapeDirectory`
       scrapeDirectory(
-        `${_path}/${item}`,
+        `${path}/${item}`,
         `${contentSubpath}/${item}`,
         repoLangCode,
         trackers
@@ -126,14 +125,14 @@ export const processLanguage = (
     error: "",
   }
   // Initialize working directory and check for existence
-  const _path: string = join(DOT_CROWDIN, crowdinLangCode)
-  if (!existsSync(_path)) {
+  const path: string = join(DOT_CROWDIN, crowdinLangCode)
+  if (!existsSync(path)) {
     trackers.langs[
       repoLangCode
     ].error = `Path doesn't exist for lang ${crowdinLangCode}`
     return
   }
-  const langLs: string[] = readdirSync(_path)
+  const langLs: string[] = readdirSync(path)
   // Iterate over each selected bucket, scraping contents with `scrapeDirectory`
   buckets.forEach((bucket) =>
     processBucket(bucket, crowdinLangCode, repoLangCode, langLs, trackers)

src/scripts/crowdin/translations/getApprovedBuckets.ts

@@ -40,6 +40,4 @@ async function getApprovedBuckets(): Promise<BucketsList> {
   return bucketsList
 }
 
-getApprovedBuckets()
-
 export default getApprovedBuckets

src/scripts/crowdin/translations/postLangPRs.ts

@@ -1,22 +1,20 @@
 import fs from "fs"
 
-import i18n from "../../../../i18n.config.json"
+import { LOCALES_CODES } from "../../../lib/constants"
 import { BucketsList } from "../import/types"
 
 import { BUCKETS_PATH } from "./constants"
-import { processLocale } from "./utils"
-
-const locales = i18n.map((lang) => lang.code)
+import { createLocaleTranslationPR } from "./utils"
 
 function postLangPRs() {
   const bucketsListRead = fs.readFileSync(BUCKETS_PATH, "utf-8")
   const bucketsList = JSON.parse(bucketsListRead) as BucketsList
 
   if (!bucketsList) throw new Error("Failed to read buckets list.")
 
-  for (const locale of locales) {
+  for (const locale of LOCALES_CODES) {
     if (!bucketsList[locale]) continue
-    processLocale(locale, bucketsList[locale])
+    createLocaleTranslationPR(locale, bucketsList[locale])
   }
 }
 

src/scripts/crowdin/translations/utils.ts

@@ -59,7 +59,10 @@ ${qaResults}
 `
 }
 
-export const processLocale = (locale: string, buckets: number[]) => {
+export const createLocaleTranslationPR = (
+  locale: string,
+  buckets: number[]
+) => {
   const gitStatus = execSync(`git status -s | grep -E "/${locale}/" | wc -l`, {
     encoding: "utf-8",
   }).trim()