Skip to content

Commit 4d8fc25

Browse files
authored
Merge pull request #13106 from ethereum/performance/optimize-hero-images
Performance: optimize hero images
2 parents f4dd825 + 7f18947 commit 4d8fc25

File tree

8 files changed

+15
-5
lines changed

8 files changed

+15
-5
lines changed

src/components/Hero/ContentHero/index.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,8 @@ const ContentHero = (props: ContentHeroProps) => {
2626
blurDataURL={blurDataURL}
2727
width={760}
2828
height={451}
29-
sizes="(max-width: 992px) 100vw, 50vw"
29+
// TODO: adjust value when the old theme breakpoints are removed (src/theme.ts)
30+
sizes="(max-width: 992px) 100vw, 760px"
3031
boxSize="full"
3132
style={{ objectFit: "contain" }}
3233
flex={{ base: "1 1 100%", md: "none" }}

src/components/Hero/HubHero/index.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,8 @@ const HubHero = ({
2626
src={heroImg}
2727
alt=""
2828
priority
29-
sizes="100vw"
29+
// TODO: adjust value when the old theme breakpoints are removed (src/theme.ts)
30+
sizes="(max-width: 1504px) 100vw, 1504px"
3031
style={{ width: "100vw", objectFit: "cover" }}
3132
h={{
3233
base: "192px",

src/components/PageHero.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,8 @@ const PageHero = ({
156156
>
157157
<Image
158158
src={image}
159-
sizes="(max-width: 992px) 100vw, 50vw"
159+
// TODO: adjust value when the old theme breakpoints are removed (src/theme.ts)
160+
sizes="(max-width: 992px) 100vw, 624px"
160161
style={{
161162
width: "100%",
162163
height: "auto",

src/layouts/Roadmap.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -185,6 +185,8 @@ export const RoadmapLayout = ({
185185
style={{ objectFit: "contain" }}
186186
width={1504}
187187
height={336}
188+
// TODO: adjust value when the old theme breakpoints are removed (src/theme.ts)
189+
sizes="(max-width: 992px) 100vw, 720px"
188190
priority
189191
/>
190192
</Center>

src/layouts/UseCases.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -216,6 +216,7 @@ export const UseCasesLayout = ({
216216
width={1200}
217217
height={610}
218218
style={{ objectFit: "cover" }}
219+
// TODO: adjust value when the old theme breakpoints are removed (src/theme.ts)
219220
sizes="(max-width: 992px) 100vw, 750px"
220221
priority
221222
alignSelf={{

src/pages/eth.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -396,7 +396,8 @@ const EthPage = () => {
396396
<Hero>
397397
<Image
398398
src={eth}
399-
width={800}
399+
// TODO: adjust value when the old theme breakpoints are removed (src/theme.ts)
400+
sizes="(max-width: 768px) 100vw, 800px"
400401
alt={t("page-eth-whats-eth-hero-alt")}
401402
priority
402403
/>

src/pages/wallets/find-wallet.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,8 @@ const FindWalletPage = () => {
165165
<Center w={{ base: "full", sm: "50%" }}>
166166
<Image
167167
src={HeroImage}
168-
width={500}
168+
// TODO: adjust value when the old theme breakpoints are removed (src/theme.ts)
169+
sizes="(max-width: 480px) 100vw, 500px"
169170
alt=""
170171
priority
171172
style={{

src/pages/what-is-ethereum.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -347,6 +347,8 @@ const WhatIsEthereumPage = ({
347347
<Image
348348
src={hero}
349349
alt={t("page-what-is-ethereum-alt-img-bazaar")}
350+
// TODO: adjust value when the old theme breakpoints are removed (src/theme.ts)
351+
sizes="(max-width: 992px) 100vw, 750px"
350352
priority
351353
/>
352354
</Hero>

0 commit comments

Comments
 (0)