Skip to content

Commit 55cd9b9

Browse files
Merge remote-tracking branch 'origin/dev' into feat/chromatic-story-modes
2 parents 73d5bf4 + fbec3c4 commit 55cd9b9

File tree

21 files changed

+621
-119
lines changed

21 files changed

+621
-119
lines changed

.all-contributorsrc

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12015,6 +12015,33 @@
1201512015
"contributions": [
1201612016
"content"
1201712017
]
12018+
},
12019+
{
12020+
"login": "raxhvl",
12021+
"name": "rahul",
12022+
"avatar_url": "https://avatars.githubusercontent.com/u/10168946?v=4",
12023+
"profile": "https://github.com/raxhvl",
12024+
"contributions": [
12025+
"content"
12026+
]
12027+
},
12028+
{
12029+
"login": "professorabhay",
12030+
"name": "Abhay Gupta ",
12031+
"avatar_url": "https://avatars.githubusercontent.com/u/76243309?v=4",
12032+
"profile": "https://abhayporwals.live/",
12033+
"contributions": [
12034+
"content"
12035+
]
12036+
},
12037+
{
12038+
"login": "somethingstup",
12039+
"name": "somethingstup",
12040+
"avatar_url": "https://avatars.githubusercontent.com/u/166286712?v=4",
12041+
"profile": "https://github.com/somethingstup",
12042+
"contributions": [
12043+
"doc"
12044+
]
1201812045
}
1201912046
],
1202012047
"contributorsPerLine": 7,
Lines changed: 74 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,74 @@
1+
name: Check for non-English updates outside of Crowdin
2+
3+
on:
4+
pull_request:
5+
paths:
6+
- "public/content/translations/**/*.md"
7+
- "src/intl/**/*.json"
8+
- "!src/intl/en/**
9+
10+
jobs:
11+
check_branch_name:
12+
runs-on: ubuntu-latest
13+
steps:
14+
- name: Exit early if branch name contains 'crowdin'
15+
run: |
16+
if [[ "${{ github.head_ref }}" == *crowdin* ]]; then
17+
echo "Branch name contains 'crowdin', stopping workflow"
18+
exit 1
19+
fi
20+
21+
check_changes:
22+
needs: check_branch_name
23+
runs-on: ubuntu-latest
24+
outputs:
25+
all_changes_include_href: ${{ steps.check.outputs.all_changes_include_href }}
26+
steps:
27+
- name: Checkout code
28+
uses: actions/checkout@v2
29+
- name: Check changes
30+
id: check
31+
run: |
32+
git fetch origin ${{ github.base_ref }}
33+
DIFF=$(git diff --no-ext-diff --unified=0 origin/${{ github.base_ref }}..${{ github.head_ref }} -- 'public/content/translations/**/*.md' 'src/intl/**/*.json' '!src/intl/en/**' | grep -E -v '^[-+]href=')
34+
if [[ -z "$DIFF" ]]; then
35+
echo "ALL_CHANGES_INCLUDE_HREF=true" >> $GITHUB_ENV
36+
else
37+
echo "ALL_CHANGES_INCLUDE_HREF=false" >> $GITHUB_ENV
38+
fi
39+
echo "::set-output name=all_changes_include_href::$ALL_CHANGES_INCLUDE_HREF"
40+
41+
add_label_and_comment:
42+
needs: check_changes
43+
runs-on: ubuntu-latest
44+
steps:
45+
- name: Add label and comment
46+
uses: actions/github-script@v5
47+
with:
48+
github-token: ${{secrets.GITHUB_TOKEN}}
49+
script: |
50+
const prNumber = context.issue.number;
51+
const repo = context.repo;
52+
const prAuthor = context.payload.pull_request.user.login;
53+
const allChangesIncludeHref = '${{ needs.check_changes.outputs.all_changes_include_href }}' === 'true';
54+
const status = allChangesIncludeHref ? 'question ❓' : 'blocked 🛑';
55+
await github.rest.issues.addLabels({
56+
...repo,
57+
issue_number: prNumber,
58+
labels: [status, 'non-crowdin translation updates']
59+
});
60+
const commentWithoutHrefs = `This pull request contains changes to non-English content, which must also be handled through the Crowdin platform instead of only on GitHub.`
61+
const commentWithHrefs = `This pull request contains changes to non-English content files, which may also need to be handled through the Crowdin platform instead of only on GitHub.
62+
await github.rest.issues.createComment({
63+
...repo,
64+
issue_number: prNumber,
65+
body: `
66+
Thank you for your contribution, @${prAuthor}!
67+
68+
${allChangesIncludeHref ? commentWithHrefs : commentWithoutHrefs}
69+
70+
We value your suggestion, and for any non-English content updates we request that you check out [how to help us translate](https://ethereum.org/en/contributing/translation-program/#help-us-translate), and suggest these updates directly in [our Crowdin project](https://crowdin.com/project/ethereum-org) if possible, where they can be properly reviewed.
71+
72+
Please post here or join [our Discord](https://ethereum.org/discord) if you have questions!
73+
`
74+
});

README.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1840,6 +1840,11 @@ Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/d
18401840
<td align="center" valign="top" width="14.28%"><a href="https://github.com/ksdumont"><img src="https://avatars.githubusercontent.com/u/51958351?v=4?s=100" width="100px;" alt="Keith Dumont"/><br /><sub><b>Keith Dumont</b></sub></a><br /><a href="#content-ksdumont" title="Content">🖋</a></td>
18411841
<td align="center" valign="top" width="14.28%"><a href="https://github.com/ecabras"><img src="https://avatars.githubusercontent.com/u/126670074?v=4?s=100" width="100px;" alt="ecabras"/><br /><sub><b>ecabras</b></sub></a><br /><a href="#content-ecabras" title="Content">🖋</a></td>
18421842
</tr>
1843+
<tr>
1844+
<td align="center" valign="top" width="14.28%"><a href="https://github.com/raxhvl"><img src="https://avatars.githubusercontent.com/u/10168946?v=4?s=100" width="100px;" alt="rahul"/><br /><sub><b>rahul</b></sub></a><br /><a href="#content-raxhvl" title="Content">🖋</a></td>
1845+
<td align="center" valign="top" width="14.28%"><a href="https://abhayporwals.live/"><img src="https://avatars.githubusercontent.com/u/76243309?v=4?s=100" width="100px;" alt="Abhay Gupta "/><br /><sub><b>Abhay Gupta </b></sub></a><br /><a href="#content-professorabhay" title="Content">🖋</a></td>
1846+
<td align="center" valign="top" width="14.28%"><a href="https://github.com/somethingstup"><img src="https://avatars.githubusercontent.com/u/166286712?v=4?s=100" width="100px;" alt="somethingstup"/><br /><sub><b>somethingstup</b></sub></a><br /><a href="https://github.com/ethereum/ethereum-org-website/commits?author=somethingstup" title="Documentation">📖</a></td>
1847+
</tr>
18431848
</tbody>
18441849
</table>
18451850

netlify.toml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,12 +41,14 @@
4141
[functions]
4242

4343
[functions.___netlify-odb-handler]
44+
external_node_modules = ["sharp"]
4445
included_files = [
4546
"./src/intl/**/*",
4647
"!./public/**/*",
4748
"node_modules/next/dist/server/future/route-modules/pages/vendored/contexts/router-context*",
4849
"node_modules/next/dist/server/future/route-modules/pages/vendored/contexts/amp-context*",
4950
"node_modules/next/dist/server/future/route-modules/pages/vendored/contexts/head-manager-context*",
51+
"node_modules/sharp/**/*",
5052
]
5153

5254
[functions.___netlify-handler]

public/content/community/events/index.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ hideEditButton: true
1111

1212
<UpcomingEventsList/>
1313

14-
This is a non-exhaustive list maintained by our community. Know of an upcoming Ethereum event to add to this list? [Please add it](https://github.com/ethereum/ethereum-org-website/blob/dev/src/data/community-events.ts)!
14+
This is a non-exhaustive list maintained by our community. Know of an upcoming Ethereum event to add to this list? [Please add it](https://github.com/ethereum/ethereum-org-website/blob/dev/src/data/community-events.json)!
1515

1616
## Ethereum meetups {#meetups}
1717

public/content/community/get-involved/index.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ Do you have a background in mathematics, cryptography, or economics? You might b
3838
- [Ethresear.ch](https://ethresear.ch) - Ethereum’s primary forum for research, and the world’s most influential forum for cryptoeconomics
3939
- [EF Research AMA](https://old.reddit.com/r/ethereum/comments/vrx9xe/ama_we_are_ef_research_pt_8_07_july_2022) - An ongoing Q&A series with researchers. As each next part opens, anyone can post questions.
4040
- [Ecosystem Support Program's wishlist](https://esp.ethereum.foundation/wishlist/) - research areas where the Ethereum Ecosystem Support Program is actively seeking grant applications
41+
- [AllWalletDevs](allwallet.dev) - a forum for Ethereum developers, designers, and interested users to come together regularly and discuss wallets
4142

4243
[Explore more active areas of research](/community/research/).
4344

public/content/community/language-resources/index.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ If you are bilingual and want to help us reach more people, you can also get inv
3232
- [Cointelegraph](http://cointelegraph.com.br/category/analysis) - Brazilian version of Cointelegraph, a major cryptocurrency news outlet
3333
- [Livecoins](http://www.livecoins.com.br/ethereum) - cryptocurrency news and tools
3434
- [Seudinheiro](http://www.seudinheiro.com/criptomoedas/) - cryptocurrency news and reports
35+
- [Modular Crypto](https://modularcrypto.xyz/) - cryptocurrency news and educational articles
3536

3637
**Education**
3738

public/content/developers/docs/intro-to-ether/index.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ As well as creating ether through block rewards, ether can be destroyed through
4040

4141
Ether burn occurs in every transaction on Ethereum. When users pay for their transactions, a base gas fee, set by the network according to transactional demand, gets destroyed. This, coupled with variable block sizes and a maximum gas fee, simplifies transaction fee estimation on Ethereum. When network demand is high, [blocks](https://etherscan.io/block/12965263) can burn more ether than they mint, effectively offsetting ether issuance.
4242

43-
Burning the base fee hinders a block producers ability to manipulate transactions. For example, if block producers received the base fee, they could include their own transactions for free and raise the base fee for everyone else. Alternatively, they could refund the base fee to some users off-chain, leading to a more opaque and complex transaction fee market.
43+
Burning the base fee hinders a block producer's ability to manipulate transactions. For example, if block producers received the base fee, they could include their own transactions for free and raise the base fee for everyone else. Alternatively, they could refund the base fee to some users off-chain, leading to a more opaque and complex transaction fee market.
4444

4545
## Denominations of ether {#denominations}
4646

public/content/developers/docs/standards/tokens/erc-4626/index.md

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ To better understand this page, we recommend you first read about [token standar
2727
#### asset {#asset}
2828

2929
```solidity
30-
function asset() public view returns (address)
30+
function asset() public view returns (address assetTokenAddress)
3131
```
3232

3333
This function returns the address of the underlying token used for the vault for accounting, depositing, withdrawing.
@@ -59,15 +59,15 @@ This function returns the amount of `assets` that would be exchanged by the vaul
5959
#### maxDeposit {#maxdeposit}
6060

6161
```solidity
62-
function maxDeposit(address receiver) public view returns (uint256)
62+
function maxDeposit(address receiver) public view returns (uint256 maxAssets)
6363
```
6464

6565
This function returns the maximum amount of underlying assets that can be deposited in a single [`deposit`](#deposit) call by the `receiver`.
6666

6767
#### previewDeposit {#previewdeposit}
6868

6969
```solidity
70-
function previewDeposit(uint256 assets) public view returns (uint256)
70+
function previewDeposit(uint256 assets) public view returns (uint256 shares)
7171
```
7272

7373
This function allows users to simulate the effects of their deposit at the current block.
@@ -83,15 +83,15 @@ This function deposits `assets` of underlying tokens into the vault and grants o
8383
#### maxMint {#maxmint}
8484

8585
```solidity
86-
function maxMint(address receiver) public view returns (uint256)
86+
function maxMint(address receiver) public view returns (uint256 maxShares)
8787
```
8888

8989
This function returns the maximum amount of shares that can be minted in a single [`mint`](#mint) call by the `receiver`.
9090

9191
#### previewMint {#previewmint}
9292

9393
```solidity
94-
function previewMint(uint256 shares) public view returns (uint256)
94+
function previewMint(uint256 shares) public view returns (uint256 assets)
9595
```
9696

9797
This function allows users to simulate the effects of their mint at the current block.
@@ -107,15 +107,15 @@ This function mints exactly `shares` vault shares to `receiver` by depositing `a
107107
#### maxWithdraw {#maxwithdraw}
108108

109109
```solidity
110-
function maxWithdraw(address owner) public view returns (uint256)
110+
function maxWithdraw(address owner) public view returns (uint256 maxAssets)
111111
```
112112

113113
This function returns the maximum amount of underlying assets that can be withdrawn from the `owner` balance with a single [`withdraw`](#withdraw) call.
114114

115115
#### previewWithdraw {#previewwithdraw}
116116

117117
```solidity
118-
function previewWithdraw(uint256 assets) public view returns (uint256)
118+
function previewWithdraw(uint256 assets) public view returns (uint256 shares)
119119
```
120120

121121
This function allows users to simulate the effects of their withdrawal at the current block.
@@ -131,15 +131,15 @@ This function burns `shares` from `owner` and send exactly `assets` token from t
131131
#### maxRedeem {#maxredeem}
132132

133133
```solidity
134-
function maxRedeem(address owner) public view returns (uint256)
134+
function maxRedeem(address owner) public view returns (uint256 maxShares)
135135
```
136136

137137
This function returns the maximum amount of shares that can be redeemed from the `owner` balance through a [`redeem`](#redeem) call.
138138

139139
#### previewRedeem {#previewredeem}
140140

141141
```solidity
142-
function previewRedeem(uint256 shares) public view returns (uint256)
142+
function previewRedeem(uint256 shares) public view returns (uint256 assets)
143143
```
144144

145145
This function allows users to simulate the effects of their redemption at the current block.
@@ -168,6 +168,10 @@ function balanceOf(address owner) public view returns (uint256)
168168

169169
Returns the total amount of vault shares the `owner` currently has.
170170

171+
### Map of the interface {#mapOfTheInterface}
172+
173+
![Map of the ERC-4626 interface](./map-of-erc-4626.png)
174+
171175
### Events {#events}
172176

173177
#### Deposit Event
70.4 KB
Loading

0 commit comments

Comments
 (0)