Skip to content

Commit 55fa6e0

Browse files
committed
fix: search modal scroll position and overlay
maintain scroll position when closing search modal, fix modal overlay to screen
1 parent a19b5bd commit 55fa6e0

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

src/components/Search/SearchModal.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,10 @@ type ModalPropsNoScroll = Omit<DocSearchModalProps, "initialScrollY">
99
const DocSearchModalWithChakra = chakra(
1010
(props: ModalPropsNoScroll & { className?: string }) => {
1111
const { className, ...docModalProps } = props
12+
const windowScrollY = typeof window === "undefined" ? 0 : window.scrollY
1213
return (
1314
<div className={className}>
14-
<DocSearchModal initialScrollY={0} {...docModalProps} />
15+
<DocSearchModal initialScrollY={windowScrollY} {...docModalProps} />
1516
</div>
1617
)
1718
}

src/components/Search/utils.ts

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,11 @@ export const getSearchModalStyles = (): SystemStyleObject => ({
7474
"--docsearch-modal-width": "650px",
7575
"--docsearch-hit-height": "fit-content",
7676

77+
".DocSearch.DocSearch-Container": {
78+
position: "fixed",
79+
inset: 0,
80+
},
81+
7782
".DocSearch-SearchBar": {
7883
p: { base: 4, md: 8 },
7984
pb: 4,
@@ -103,10 +108,9 @@ export const getSearchModalStyles = (): SystemStyleObject => ({
103108
},
104109
},
105110

106-
".DocSearch-Container--Stalled .DocSearch-MagnifierLabel, .DocSearch-Container--Stalled .DocSearch-LoadingIndicator":
107-
{
108-
color: "primary.highContrast",
109-
},
111+
".DocSearch-Container--Stalled .DocSearch-MagnifierLabel, .DocSearch-Container--Stalled .DocSearch-LoadingIndicator": {
112+
color: "primary.highContrast",
113+
},
110114

111115
".DocSearch-Dropdown": {
112116
ps: { base: 4, md: 8 },

0 commit comments

Comments
 (0)