revert: cookie usage

wackerow · wackerow · commit 6d1d7012740e · 2025-07-01T19:50:37.000-07:00
diff --git a/src/components/AB/TestDebugPanel.tsx b/src/components/AB/TestDebugPanel.tsx
@@ -5,11 +5,9 @@ import { useRouter } from "next/navigation"
 
 import { cn } from "@/lib/utils/cn"
 
-import { AB_TEST_COOKIE_PREFIX } from "@/lib/constants"
-
 import { Button } from "../ui/buttons/Button"
 
-import { clearABTestCookie, forceABTestVariant } from "@/lib/ab-testing/actions"
+import { forceABTestVariant } from "@/lib/ab-testing/actions"
 import { ABTestAssignment } from "@/lib/ab-testing/types"
 
 type ABTestDebugPanelProps = {
@@ -33,28 +31,11 @@ export function ABTestDebugPanel({
     setLocalAssignment(currentAssignment)
   }, [currentAssignment])
 
-  const cookieName = AB_TEST_COOKIE_PREFIX + testKey
-  // Check if cookie exists client-side and set fallback if needed
-  useEffect(() => {
-    if (currentAssignment) {
-      const cookieExists = document.cookie.includes(cookieName)
-
-      if (!cookieExists) {
-        console.log(`[AB Test Debug] Setting fallback cookie for ${testKey}`)
-        document.cookie = `${cookieName}=${JSON.stringify(currentAssignment)}; max-age=${60 * 60 * 24 * 30}; path=/; samesite=lax`
-      }
-    }
-  }, [cookieName, currentAssignment, testKey])
-
   const forceVariant = async (variantName: string) => {
     try {
       const newAssignment = await forceABTestVariant(testKey, variantName)
       setLocalAssignment(newAssignment)
 
-      // Fallback: Set cookie client-side if server action doesn't persist
-      document.cookie = `${cookieName}=${JSON.stringify(newAssignment)}; max-age=${60 * 60 * 24 * 30}; path=/; samesite=lax`
-
-      // Use transition for smoother updates without full refresh
       startTransition(() => {
         router.refresh()
       })
@@ -63,41 +44,13 @@ export function ABTestDebugPanel({
     }
   }
 
-  const clearCookie = async () => {
-    try {
-      await clearABTestCookie(testKey)
-
-      // Fallback: Clear cookie client-side as well
-      document.cookie = `${cookieName}=; expires=Thu, 01 Jan 1970 00:00:00 GMT; path=/`
-
-      setLocalAssignment(null)
-      // Use transition for smoother updates without full refresh
-      startTransition(() => {
-        router.refresh()
-      })
-    } catch (error) {
-      console.error("Failed to clear cookie:", error)
-    }
-  }
-
-  const resetAllTests = () => {
-    // Clear all AB test cookies and reload page
-    document.cookie.split(";").forEach((cookie) => {
-      const [name] = cookie.split("=")
-      if (name.trim().startsWith(AB_TEST_COOKIE_PREFIX)) {
-        document.cookie = `${name.trim()}=; expires=Thu, 01 Jan 1970 00:00:00 GMT; path=/`
-      }
-    })
-    window.location.reload()
-  }
-
   return (
-    <div className="fixed bottom-5 right-5 z-sticky rounded-lg border-2 bg-background-low p-2.5 font-mono text-xs">
+    <div className="fixed bottom-5 right-5 z-modal rounded-lg border-2 bg-background-low p-2.5 font-mono text-xs">
       <Button
         onClick={() => setIsOpen(!isOpen)}
         className="w-full cursor-pointer rounded border-none bg-accent-a px-2.5 py-1 font-semibold text-white hover:bg-accent-a-hover"
       >
-        🧪 AB Test Debug
+        🧪 AB Test Switcher
       </Button>
 
       {isOpen && (
@@ -111,16 +64,9 @@ export function ABTestDebugPanel({
               <span className="ml-2 text-xs text-gray-500">Loading...</span>
             )}
           </div>
-          <div className="mt-1 text-2xs">
-            <strong>Cookie:</strong>{" "}
-            {typeof window !== "undefined" &&
-            document.cookie.includes(AB_TEST_COOKIE_PREFIX + testKey)
-              ? "✓ Set"
-              : "✗ Missing"}
-          </div>
           <div className="mt-2.5">
             <div>
-              <strong>Force Variant:</strong>
+              <strong>Force variant:</strong>
             </div>
             {availableVariants.map((variant) => (
               <Button
@@ -141,30 +87,6 @@ export function ABTestDebugPanel({
                 {variant}
               </Button>
             ))}
-            <div className="mt-2.5 flex gap-1">
-              <Button
-                onClick={clearCookie}
-                disabled={isPending}
-                className={cn(
-                  "flex-1 rounded border-none bg-warning px-2 py-1 text-xs text-black hover:bg-warning-dark",
-                  isPending ? "cursor-not-allowed opacity-60" : "cursor-pointer"
-                )}
-                title="Clear this test's cookie and get new random assignment"
-              >
-                🔄 Reset Test
-              </Button>
-              <Button
-                onClick={resetAllTests}
-                disabled={isPending}
-                className={cn(
-                  "flex-1 rounded border-none bg-error px-2 py-1 text-xs text-white hover:bg-error-dark",
-                  isPending ? "cursor-not-allowed opacity-60" : "cursor-pointer"
-                )}
-                title="Clear all AB test cookies and reload page"
-              >
-                🗑️ Reset All
-              </Button>
-            </div>
           </div>
         </div>
       )}
diff --git a/src/components/AB/TestWrapper.tsx b/src/components/AB/TestWrapper.tsx
@@ -21,7 +21,7 @@ const ABTestWrapper = async ({
   fallback,
 }: ABTestWrapperProps) => {
   try {
-    // Get deterministic assignment (cookieless, based on user fingerprint)
+    // Get deterministic assignment (cookie-less, based on fingerprint)
     const assignment = await getABTestAssignment(testKey)
 
     if (!assignment) {
diff --git a/src/lib/ab-testing/actions.ts b/src/lib/ab-testing/actions.ts
@@ -1,34 +1,12 @@
 "use server"
 
-import { cookies } from "next/headers"
-
-import { AB_TEST_COOKIE_PREFIX } from "../constants"
-import { IS_PROD } from "../utils/env"
-
 import { getABTestConfigs } from "./config"
 import { ABTestAssignment } from "./types"
 
-// Server Action to set AB test assignment cookie
-export async function setABTestCookie(
-  testKey: string,
-  assignment: ABTestAssignment
-) {
-  const cookieStore = await cookies()
-  const cookieName = AB_TEST_COOKIE_PREFIX + testKey
-  const maxAge = 60 * 60 * 24 * 30 // 30 days
-
-  cookieStore.set(cookieName, JSON.stringify(assignment), {
-    maxAge,
-    httpOnly: false, // Needs to be accessible by client for potential debugging
-    secure: IS_PROD,
-    sameSite: "lax",
-    path: "/",
-  })
-}
-
-// Server action to manually set a specific variant for testing
+// Server action to create a specific variant assignment for debug panel testing
+// Note: This doesn't persist anywhere - it's just for debug panel state
 export async function forceABTestVariant(testKey: string, variantName: string) {
-  const configs = getABTestConfigs()
+  const configs = await getABTestConfigs()
   const testConfig = configs[testKey]
 
   if (!testConfig) {
@@ -42,36 +20,10 @@ export async function forceABTestVariant(testKey: string, variantName: string) {
 
   const assignment: ABTestAssignment = {
     experimentId: testConfig.id,
-    experimentName: testConfig.name,
+    experimentName: testConfig.name || testKey,
     variant: variantName,
     assignedAt: Date.now(),
   }
 
-  const cookieStore = await cookies()
-  const cookieName = `${AB_TEST_COOKIE_PREFIX}${testKey}`
-  const maxAge = 60 * 60 * 24 * 30 // 30 days
-
-  cookieStore.set(cookieName, JSON.stringify(assignment), {
-    maxAge,
-    httpOnly: false,
-    secure: IS_PROD,
-    sameSite: "lax",
-    path: "/",
-  })
-
-  if (process.env.NODE_ENV === "development") {
-    console.log(`[AB Test] Forced variant ${variantName} for test ${testKey}`)
-  }
   return assignment
 }
-
-// Server action to clear AB test cookie
-export async function clearABTestCookie(testKey: string) {
-  const cookieStore = await cookies()
-  const cookieName = `${AB_TEST_COOKIE_PREFIX}${testKey}`
-
-  cookieStore.delete(cookieName)
-  if (process.env.NODE_ENV === "development") {
-    console.log(`[AB Test] Cleared cookie for test ${testKey}`)
-  }
-}
diff --git a/src/lib/ab-testing/server.ts b/src/lib/ab-testing/server.ts
@@ -1,7 +1,3 @@
-import { cookies } from "next/headers"
-
-import { AB_TEST_COOKIE_PREFIX } from "../constants"
-
 import { getABTestConfigs, getABTestConfigsSync } from "./config"
 import { ABTestAssignment, ABTestConfig } from "./types"
 
@@ -15,23 +11,7 @@ export async function getABTestAssignment(
     return null
   }
 
-  const cookieStore = await cookies()
-  const cookieName = AB_TEST_COOKIE_PREFIX + testKey
-  const existingAssignment = cookieStore.get(cookieName)
-
-  if (existingAssignment?.value) {
-    try {
-      const parsed: ABTestAssignment = JSON.parse(existingAssignment.value)
-      // Validate that the variant still exists in current config
-      if (testConfig.variants.some((v) => v.name === parsed.variant)) {
-        return parsed
-      }
-    } catch (error) {
-      // Invalid cookie format, continue to reassign
-    }
-  }
-
-  // If no valid existing assignment, create deterministic assignment
+  // Create deterministic assignment
   // Use IP + User-Agent as fingerprint for consistent assignment (cookie-less)
   const headers = await import("next/headers").then((m) => m.headers())
   const userAgent = headers.get("user-agent") || ""
diff --git a/src/lib/constants.ts b/src/lib/constants.ts
@@ -12,7 +12,6 @@ export const TRANSLATED_IMAGES_DIR = "/content/translations"
 export const PLACEHOLDER_IMAGE_DIR = "src/data/placeholders"
 export const INTERNAL_TUTORIALS_JSON = "src/data/internalTutorials.json"
 export const INTL_JSON_DIR = "src/intl"
-export const AB_TEST_COOKIE_PREFIX = "_pk_abtest_"
 
 export const NULL_VALUE = "—"
 
