Skip to content

Commit 72470f0

Browse files
committed
fix: mobile picker positioning
resolves RTL positioning bug
1 parent 8c3576e commit 72470f0

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/components/LanguagePicker/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ import { useLanguagePicker } from "./useLanguagePicker"
2525

2626
type LanguagePickerProps = Omit<MenuListProps, "children"> & {
2727
children: React.ReactNode
28-
placement: MenuProps["placement"]
28+
placement?: MenuProps["placement"]
2929
handleClose?: () => void
3030
menuState?: UseDisclosureReturn
3131
}

src/components/Nav/Mobile.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -337,8 +337,8 @@ const MobileNavMenu: React.FC<IProps> = ({
337337
<FooterItemText>{t(themeLabelKey)}</FooterItemText>
338338
</FooterButton>
339339
<LanguagePicker
340-
placement="top-end"
341-
h="calc(100svh - var(--eth-sizes-8))"
340+
hideFrom="lg" // TODO: Confirm breakpoint after nav-menu PR merged
341+
position="fixed"
342342
w="calc(100vw - var(--eth-sizes-8))"
343343
inset="4"
344344
handleClose={onToggle}

0 commit comments

Comments
 (0)