Skip to content

Commit 83f808d

Browse files
committed
fix infinite loop with router.query
1 parent f0d4913 commit 83f808d

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

src/components/ProductTable/index.tsx

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@ import PresetFilters from "@/components/ProductTable/PresetFilters"
1818

1919
import { trackCustomEvent } from "@/lib/utils/matomo"
2020

21-
import { usePathname } from "@/i18n/routing"
22-
2321
interface ProductTableProps<T> {
2422
columns: ColumnDef<T>[]
2523
data: T[]
@@ -50,7 +48,6 @@ const ProductTable = <T,>({
5048
meta,
5149
}: ProductTableProps<T>) => {
5250
const router = useRouter()
53-
const pathname = usePathname()
5451
const [activePresets, setActivePresets] = useState<number[]>([])
5552
const [mobileFiltersOpen, setMobileFiltersOpen] = useState(false)
5653

@@ -93,9 +90,11 @@ const ProductTable = <T,>({
9390
})),
9491
}))
9592
setFilters(updatedFilters)
96-
router.replace(pathname, undefined, { shallow: true })
93+
94+
// TODO: Fix this, removed to avoid infinite re-renders
95+
// router.replace(pathname, undefined, { shallow: true })
9796
}
98-
}, [router])
97+
}, [router.query])
9998

10099
// Update or remove preset filters
101100
const handleSelectPreset = (idx: number) => {

0 commit comments

Comments
 (0)