Skip to content

Commit 85a1737

Browse files
committed
chore: apply suggestions
1 parent 8189815 commit 85a1737

File tree

1 file changed

+10
-5
lines changed

1 file changed

+10
-5
lines changed

.github/workflows/non-english-warning.yml

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ jobs:
3030
id: check
3131
run: |
3232
git fetch origin ${{ github.base_ref }}
33-
DIFF=$(git diff --no-ext-diff --unified=0 origin/${{ github.base_ref }}..${{ github.head_ref }} -- 'public/content/translations/**/*.md' 'src/intl/**/*.json' '!src/intl/en/**' | egrep -v '^[-+]href=')
33+
DIFF=$(git diff --no-ext-diff --unified=0 origin/${{ github.base_ref }}..${{ github.head_ref }} -- 'public/content/translations/**/*.md' 'src/intl/**/*.json' '!src/intl/en/**' | grep -E -v '^[-+]href=')
3434
if [[ -z "$DIFF" ]]; then
3535
echo "ALL_CHANGES_INCLUDE_HREF=true" >> $GITHUB_ENV
3636
else
@@ -57,14 +57,19 @@ jobs:
5757
issue_number: prNumber,
5858
labels: [status, 'non-crowdin translation updates']
5959
});
60-
const commentWithoutHrefs = `This pull request contains changes to non-English content, which must be handled through the Crowdin platform instead of GitHub.`
61-
const commentWithHrefs = `This pull request contains changes to non-English content files, which may need to be handled through the Crowdin platform instead of GitHub.
60+
const commentWithoutHrefs = `This pull request contains changes to non-English content, which must also be handled through the Crowdin platform instead of only on GitHub.`
61+
const commentWithHrefs = `This pull request contains changes to non-English content files, which may also need to be handled through the Crowdin platform instead of only on GitHub.
6262
If these changes include _only_ changes to link `href` values (or other non-translated string segments), please disregard this message.`
6363
await github.rest.issues.createComment({
6464
...repo,
6565
issue_number: prNumber,
66-
body: `Thank you for your contribution, @${prAuthor}!
66+
body: `
67+
Thank you for your contribution, @${prAuthor}!
68+
6769
${allChangesIncludeHref ? commentWithHrefs : commentWithoutHrefs}
70+
6871
We value your suggestion, and for any non-English content updates we request that you check out [how to help us translate](https://ethereum.org/en/contributing/translation-program/#help-us-translate), and suggest these updates directly in [our Crowdin project](https://crowdin.com/project/ethereum-org) if possible, where they can be properly reviewed.
69-
Please post here or join [our Discord](https://ethereum.org/discord) if you have questions!`
72+
73+
Please post here or join [our Discord](https://ethereum.org/discord) if you have questions!
74+
`
7075
});

0 commit comments

Comments
 (0)