remove test helpers

Author: pettinarip

tests/e2e/find-wallet.spec.ts

@@ -1,15 +1,14 @@
 import { takeSnapshot, test } from "@chromatic-com/playwright"
 
 import { FindWalletPage } from "./pages/FindWalletPage"
-import { waitForPageReady } from "./utils/testHelpers"
 
 test.describe("Find Wallet Page", () => {
   let findWalletPage: FindWalletPage
 
   test.beforeEach(async ({ page }) => {
     findWalletPage = new FindWalletPage(page)
     await findWalletPage.goto()
-    await waitForPageReady(page)
+    await findWalletPage.waitForPageReady()
   })
 
   test("loads successfully", async ({ page }, testInfo) => {

tests/e2e/global.spec.ts

@@ -5,7 +5,6 @@ import { DEFAULT_LOCALE } from "@/lib/constants"
 
 import { testData } from "./fixtures/testData"
 import { HomePage } from "./pages/HomePage"
-import { waitForPageReady } from "./utils/testHelpers"
 
 test.describe("Global", () => {
   test.describe("Error Handling", () => {
@@ -35,7 +34,7 @@ test.describe("Global", () => {
     test.beforeEach(async ({ page }) => {
       homePage = new HomePage(page)
       await homePage.goto()
-      await waitForPageReady(page)
+      await homePage.waitForPageReady()
     })
 
     async function switchToChinese(page: Page, homePage: HomePage) {
@@ -70,7 +69,6 @@ test.describe("Global", () => {
 
     test.beforeEach(async ({ page }) => {
       homePage = new HomePage(page)
-      await waitForPageReady(page)
     })
 
     async function switchToArabic(page: Page, homePage: HomePage) {
@@ -83,15 +81,15 @@ test.describe("Global", () => {
 
     test("home page RTL visual snapshot", async ({ page }, testInfo) => {
       await page.goto("/ar")
-      await waitForPageReady(page)
+      await homePage.waitForPageReady()
       await takeSnapshot(page, "home-arabic-rtl", testInfo)
     })
 
     test("nav flips logo and search button when switching to RTL via language picker", async ({
       page,
     }) => {
       await homePage.goto()
-      await waitForPageReady(page)
+      await homePage.waitForPageReady()
 
       await homePage.assertUrlMatches(`/${DEFAULT_LOCALE}/`)
 

tests/e2e/home.spec.ts

@@ -2,15 +2,14 @@ import { takeSnapshot, test } from "@chromatic-com/playwright"
 
 import { testData } from "./fixtures/testData"
 import { HomePage } from "./pages/HomePage"
-import { waitForPageReady } from "./utils/testHelpers"
 
 test.describe("Home Page", () => {
   let homePage: HomePage
 
   test.beforeEach(async ({ page }) => {
     homePage = new HomePage(page)
     await homePage.goto()
-    await waitForPageReady(page)
+    await homePage.waitForPageReady()
   })
 
   test("loads successfully", async ({ page }, testInfo) => {

tests/e2e/pages/BasePage.ts

@@ -37,6 +37,13 @@ export class BasePage {
     return viewport ? viewport.width <= breakpointAsNumber.md : false
   }
 
+  /**
+   * Wait for page to be fully loaded with all network requests completed
+   */
+  async waitForPageReady(timeout = 30000): Promise<void> {
+    await this.page.waitForLoadState("networkidle", { timeout })
+  }
+
   /**
    * Wait for page to be loaded and ready
    */